Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1052773002: cc: Add a rails argument to InputHandler::ScrollBy (Closed)

Created:
5 years, 8 months ago by ccameron
Modified:
5 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add a rails argument to InputHandler::ScrollBy This had previously been left as a TODO in InputHandlerProxy in work that had needed to be merged. BUG=468454

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Fix comiple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -238 lines) Patch
M cc/input/input_handler.h View 2 chunks +8 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 91 chunks +312 lines, -149 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 2 5 chunks +25 lines, -14 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 36 chunks +195 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ccameron
Paying down technical debt from M42.
5 years, 8 months ago (2015-04-02 16:21:46 UTC) #2
aelias_OOO_until_Jul13
lgtm
5 years, 8 months ago (2015-04-02 17:51:56 UTC) #3
enne (OOO)
lgtm as well
5 years, 8 months ago (2015-04-02 19:45:54 UTC) #4
ccameron
Thanks! jdduke is suggesting in https://codereview.chromium.org/1052433003/ that this may not be the way to go ...
5 years, 8 months ago (2015-04-02 19:52:43 UTC) #5
aelias_OOO_until_Jul13
5 years, 8 months ago (2015-04-02 20:59:59 UTC) #7
It might be -- I haven't made up my mind, I'm trying to wrap my head around
rails customization right now.

Powered by Google App Engine
This is Rietveld 408576698