Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1052753004: [turbofan] Rework handling of loop exits in loop peeling. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rework handling of loop exits in loop peeling. This CL primarily makes the loop peeling algorithm more robust; it no longer damages the graph if the loops are improperly closed. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/0b4dfc231263fbe5016f5c2c9e2d2e2fa1c154a1 Cr-Commit-Position: refs/heads/master@{#27620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -67 lines) Patch
M src/compiler/loop-analysis.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/loop-analysis.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/loop-peeling.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/loop-peeling.cc View 2 chunks +55 lines, -61 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 2 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 8 months ago (2015-04-07 09:19:40 UTC) #1
Benedikt Meurer
LGTM
5 years, 8 months ago (2015-04-07 09:32:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052753004/1
5 years, 8 months ago (2015-04-07 10:38:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 11:00:46 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 11:00:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b4dfc231263fbe5016f5c2c9e2d2e2fa1c154a1
Cr-Commit-Position: refs/heads/master@{#27620}

Powered by Google App Engine
This is Rietveld 408576698