[turbofan] Rework handling of loop exits in loop peeling.

src/compiler/loop-peeling.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/loop-peeling.h"
 #include "src/compiler/node.h"
 #include "src/compiler/node-marker.h"
 #include "src/compiler/node-properties.h"
@@ skipping 143 matching lines @@
   // TODO(turbofan): we use a simple linear search, since the peeled iteration
   // is really only used in testing.
   PeeledIterationImpl* impl = static_cast<PeeledIterationImpl*>(this);
   for (size_t i = 0; i < impl->node_pairs_.size(); i += 2) {
     if (impl->node_pairs_[i] == node) return impl->node_pairs_[i + 1];
   }
   return node;
 }
 
 
+static void FindLoopExits(LoopTree* loop_tree, LoopTree::Loop* loop,
+                          NodeVector& exits, NodeVector& rets) {
+  // Look for returns and if projections that are outside the loop but whose
+  // control input is inside the loop.
+  for (Node* node : loop_tree->LoopNodes(loop)) {
+    for (Node* use : node->uses()) {
+      if (!loop_tree->Contains(loop, use)) {
+        if (IrOpcode::IsIfProjectionOpcode(use->opcode())) {
+          // This is a branch from inside the loop to outside the loop.
+          exits.push_back(use);
+        } else if (use->opcode() == IrOpcode::kReturn &&
+                   loop_tree->Contains(loop,
+                                       NodeProperties::GetControlInput(use))) {
+          // This is a return from inside the loop.
+          rets.push_back(use);
+        }
+      }
+    }
+  }
+}
+
+
+bool LoopPeeler::CanPeel(LoopTree* loop_tree, LoopTree::Loop* loop) {
+  Zone zone;
+  NodeVector exits(&zone);
+  NodeVector rets(&zone);
+  FindLoopExits(loop_tree, loop, exits, rets);
+  return exits.size() <= 1u;
+}
+
+
 PeeledIteration* LoopPeeler::Peel(Graph* graph, CommonOperatorBuilder* common,
                                   LoopTree* loop_tree, LoopTree::Loop* loop,
                                   Zone* tmp_zone) {
-  PeeledIterationImpl* iter = new (tmp_zone) PeeledIterationImpl(tmp_zone);
-  Peeling peeling(graph, tmp_zone, loop->TotalSize() * 2 + 2,
-                  &iter->node_pairs_);
+  //============================================================================
+  // Find the loop exit region to determine if this loop can be peeled.
+  //============================================================================
+  NodeVector exits(tmp_zone);
+  NodeVector rets(tmp_zone);
+  FindLoopExits(loop_tree, loop, exits, rets);
+
+  if (exits.size() != 1) return nullptr;  // not peelable currently.
 
   //============================================================================
   // Construct the peeled iteration.
   //============================================================================
+  PeeledIterationImpl* iter = new (tmp_zone) PeeledIterationImpl(tmp_zone);
+  size_t estimated_peeled_size =
+      5 + (loop->TotalSize() + exits.size() + rets.size()) * 2;
+  Peeling peeling(graph, tmp_zone, estimated_peeled_size, &iter->node_pairs_);
+
   Node* dead = graph->NewNode(common->Dead());
 
   // Map the loop header nodes to their entry values.
   for (Node* node : loop_tree->HeaderNodes(loop)) {
-    // TODO(titzer): assuming loop entry at index 0.
-    peeling.Insert(node, node->InputAt(0));
+    peeling.Insert(node, node->InputAt(kAssumedLoopEntryIndex));
   }
 
   // Copy all the nodes of loop body for the peeled iteration.
   peeling.CopyNodes(graph, tmp_zone, dead, loop_tree->BodyNodes(loop));
 
   //============================================================================
   // Replace the entry to the loop with the output of the peeled iteration.
   //============================================================================
   Node* loop_node = loop_tree->GetLoopControl(loop);
   Node* new_entry;
@@ skipping 30 matching lines @@
     // Only one backedge, simply replace the input to loop with output of
     // peeling.
     for (Node* node : loop_tree->HeaderNodes(loop)) {
       node->ReplaceInput(0, peeling.map(node->InputAt(0)));
     }
     new_entry = peeling.map(loop_node->InputAt(1));
   }
   loop_node->ReplaceInput(0, new_entry);
 
   //============================================================================
-  // Find the loop exit region.
-  //============================================================================
-  NodeVector exits(tmp_zone);
-  Node* end = NULL;
-  for (Node* node : loop_tree->LoopNodes(loop)) {
-    for (Node* use : node->uses()) {
-      if (!loop_tree->Contains(loop, use)) {
-        if (node->opcode() == IrOpcode::kBranch &&
-            (use->opcode() == IrOpcode::kIfTrue ||
-             use->opcode() == IrOpcode::kIfFalse)) {
-          // This is a branch from inside the loop to outside the loop.
-          exits.push_back(use);
-        }
-      }
-    }
-  }
-
-  if (exits.size() == 0) return iter;  // no exits => NTL
-
-  if (exits.size() == 1) {
-    // Only one exit, so {end} is that exit.
-    end = exits[0];
-  } else {
-    // {end} should be the common merge from the exits.
-    NodeVector rets(tmp_zone);
-    for (Node* exit : exits) {
-      Node* found = NULL;
-      for (Node* use : exit->uses()) {
-        if (use->opcode() == IrOpcode::kMerge) {
-          found = use;
-          if (end == NULL) {
-            end = found;
-          } else {
-            CHECK_EQ(end, found);  // it should be unique!
-          }
-        } else if (use->opcode() == IrOpcode::kReturn) {
-          found = use;
-          rets.push_back(found);
-        }
-      }
-      // There should be a merge or a return for each exit.
-      CHECK(found);
-    }
-    // Return nodes, the end merge, and the phis associated with the end merge
-    // must be duplicated as well.
-    for (Node* node : rets) exits.push_back(node);
-    if (end != NULL) {
-      exits.push_back(end);
-      for (Node* use : end->uses()) {
-        if (NodeProperties::IsPhi(use)) exits.push_back(use);
-      }
-    }
-  }
-
-  //============================================================================
   // Duplicate the loop exit region and add a merge.
   //============================================================================
+
+  // Currently we are limited to peeling loops with a single exit. The exit is
+  // the postdominator of the loop (ignoring returns).
+  Node* postdom = exits[0];
+  for (Node* node : rets) exits.push_back(node);
+  for (Node* use : postdom->uses()) {
+    if (NodeProperties::IsPhi(use)) exits.push_back(use);
+  }
+
   NodeRange exit_range(&exits[0], &exits[0] + exits.size());
   peeling.CopyNodes(graph, tmp_zone, dead, exit_range);
 
-  Node* merge = graph->NewNode(common->Merge(2), end, peeling.map(end));
-  end->ReplaceUses(merge);
-  merge->ReplaceInput(0, end);  // HULK SMASH!!
+  Node* merge = graph->NewNode(common->Merge(2), postdom, peeling.map(postdom));
+  postdom->ReplaceUses(merge);
+  merge->ReplaceInput(0, postdom);  // input 0 overwritten by above line.
 
   // Find and update all the edges into either the loop or exit region.
   for (int i = 0; i < 2; i++) {
     NodeRange range = i == 0 ? loop_tree->LoopNodes(loop) : exit_range;
     ZoneVector<Edge> value_edges(tmp_zone);
     ZoneVector<Edge> effect_edges(tmp_zone);
 
     for (Node* node : range) {
       // Gather value and effect edges from outside the region.
       for (Edge edge : node->use_edges()) {
@@ skipping 27 matching lines @@
       }
     }
   }
 
   return iter;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8