Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: Source/core/animation/ElementAnimation.h

Issue 105273010: Web Animations API: Start implementation of timing input objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change to use Dictionary instead of Object Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/ElementAnimation.h
diff --git a/Source/core/animation/ElementAnimation.h b/Source/core/animation/ElementAnimation.h
index 16601f65df8ddbbb4bb25504e79d4af0b24cbdc4..8a55446b0a0fa3d387a7f3df3d23a61a57efeea9 100644
--- a/Source/core/animation/ElementAnimation.h
+++ b/Source/core/animation/ElementAnimation.h
@@ -41,10 +41,11 @@ class Element;
class ElementAnimation {
public:
static CSSPropertyID camelCaseCSSPropertyNameToID(StringImpl* propertyName);
- static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector, double duration = 0);
+ static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector);
+ static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector, ScriptValue timingInput);
private:
- static void startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector, double duration = 0);
+ static void startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector, v8::Handle<v8::Value> = v8::Handle<v8::Value>());
Steve Block 2013/12/17 00:05:35 You should name this new param
rjwright 2013/12/18 04:17:14 Done.
friend class AnimationElementAnimationTest;
};
« no previous file with comments | « no previous file | Source/core/animation/ElementAnimation.cpp » ('j') | Source/core/animation/ElementAnimation.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698