Source/core/animation/ElementAnimation.h - Issue 105273010: Web Animations API: Start implementation of timing input objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/animation/ElementAnimation.h

Issue 105273010: Web Animations API: Start implementation of timing input objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change to use Dictionary instead of Object Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 23 matching lines...) Expand all Loading...
34 #include "bindings/v8/Dictionary.h"	34 #include "bindings/v8/Dictionary.h"

35 #include "core/css/CSSParser.h"	35 #include "core/css/CSSParser.h"

36	36

37 namespace WebCore {	37 namespace WebCore {

38	38

39 class Element;	39 class Element;

40	40

41 class ElementAnimation {	41 class ElementAnimation {

42 public:	42 public:

43 static CSSPropertyID camelCaseCSSPropertyNameToID(StringImpl* propertyName);	43 static CSSPropertyID camelCaseCSSPropertyNameToID(StringImpl* propertyName);

44 static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector, double duration = 0);	44 static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector);

	45 static void animate(Element*, Vector<Dictionary> keyframesDictionaryVector, ScriptValue timingInput);

45	46

46 private:	47 private:

47 static void startAnimation(Element*, Vector<Dictionary> keyframesDictionaryV ector, double duration = 0);	48 static void startAnimation(Element*, Vector<Dictionary> keyframesDictionaryV ector, v8::Handle<v8::Value> = v8::Handle<v8::Value>());
	Steve Block 2013/12/17 00:05:35 You should name this new param You should name this new param rjwright 2013/12/18 04:17:14 Done. Show quoted text On 2013/12/17 00:05:35, Steve Block wrote: > You should name this new param Done.
48	49

49 friend class AnimationElementAnimationTest;	50 friend class AnimationElementAnimationTest;

50 };	51 };

51	52

52 } // namespace WebCore	53 } // namespace WebCore

53	54

54 #endif // ElementAnimation_h	55 #endif // ElementAnimation_h

OLD	NEW

« no previous file with comments | « no previous file | Source/core/animation/ElementAnimation.cpp » ('j') | Source/core/animation/ElementAnimation.cpp » ('J')