Expose kDeviceLoginScreenDomainAutoComplete through CrosSettings

chromeos/settings/cros_settings_names.cc

Index: chromeos/settings/cros_settings_names.cc
diff --git a/chromeos/settings/cros_settings_names.cc b/chromeos/settings/cros_settings_names.cc
index 921f1b2d328afd5c580277f7b3ae177836b60c2c..c51033e7b57f1d8297b9e4c8cb422a1238186674 100644
--- a/chromeos/settings/cros_settings_names.cc
+++ b/chromeos/settings/cros_settings_names.cc
@@ -38,6 +38,10 @@ const char kAccountsPrefSupervisedUsersEnabled[] =
     "cros.accounts.supervisedUsersEnabled";
 const char kAccountsPrefTransferSAMLCookies[] =
     "cros.accounts.transferSAMLCookies";

[Mattias Nissler (ping if slow), 2015/04/07 12:29:45]

nit: blank line before comment.

[peletskyi, 2015/04/07 13:48:12]

Done.

+// A string pref that specifies a domain name for the autocomplete option during
+// user sign-in flow.
+const char kAccountsPrefDeviceLoginScreenDomainAutoComplete[] =

[Daniel Erat, 2015/04/07 13:46:47]

i'm trying to parse the names of all of these constants. does "device" indicate
that it's a device-level, rather than user-level, pref? the earlier constants
with crazy camel-cased values, like
kAccountsPrefDeviceLocalAccountPromptForNetworkWhenOffline, look like they
additionally contain "device" in their values, which this one doesn't.

should it "just" be:

  kAccountsPrefLoginScreenDomainAutoComplete

, i.e. no "device" in the name?

+    "cros.accounts.login_screen_domain_auto_complete";
 
 // All cros.signed.* settings are stored in SignedSettings.
 const char kSignedDataRoamingEnabled[] = "cros.signed.data_roaming_enabled";