Expose kDeviceLoginScreenDomainAutoComplete through CrosSettings

chromeos/settings/cros_settings_names.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/settings/cros_settings_names.h"
 
 namespace chromeos {
 
 const char kCrosSettingsPrefix[] = "cros.";
 
@@ skipping 19 matching lines @@
     "cros.accounts.deviceLocalAccountAutoLoginId";
 const char kAccountsPrefDeviceLocalAccountAutoLoginDelay[] =
     "cros.accounts.deviceLocalAccountAutoLoginDelay";
 const char kAccountsPrefDeviceLocalAccountAutoLoginBailoutEnabled[] =
     "cros.accounts.deviceLocalAccountAutoLoginBailoutEnabled";
 const char kAccountsPrefDeviceLocalAccountPromptForNetworkWhenOffline[] =
     "cros.accounts.deviceLocalAccountPromptForNetworkWhenOffline";
 const char kAccountsPrefSupervisedUsersEnabled[] =
     "cros.accounts.supervisedUsersEnabled";
 const char kAccountsPrefTransferSAMLCookies[] =
     "cros.accounts.transferSAMLCookies";

[Mattias Nissler (ping if slow), 2015/04/07 12:29:45]

nit: blank line before comment.

[peletskyi, 2015/04/07 13:48:12]

Done.

+// A string pref that specifies a domain name for the autocomplete option during
+// user sign-in flow.
+const char kAccountsPrefDeviceLoginScreenDomainAutoComplete[] =

[Daniel Erat, 2015/04/07 13:46:47]

i'm trying to parse the names of all of these constants. does "device" indicate
that it's a device-level, rather than user-level, pref? the earlier constants
with crazy camel-cased values, like
kAccountsPrefDeviceLocalAccountPromptForNetworkWhenOffline, look like they
additionally contain "device" in their values, which this one doesn't.

should it "just" be:

  kAccountsPrefLoginScreenDomainAutoComplete

, i.e. no "device" in the name?

+    "cros.accounts.login_screen_domain_auto_complete";
 
 // All cros.signed.* settings are stored in SignedSettings.
 const char kSignedDataRoamingEnabled[] = "cros.signed.data_roaming_enabled";
 
 // True if auto-update was disabled by the system administrator.
 const char kUpdateDisabled[] = "cros.system.updateDisabled";
 
 // A list of strings which specifies allowed connection types for
 // update.
 const char kAllowedConnectionTypesForUpdate[] =
@@ skipping 109 matching lines @@
 // A boolean pref that indicates whether the device automatically reboots when
 // the user initiates a shutdown via an UI element.  If set to true, all
 // shutdown buttons in the UI will be replaced by reboot buttons.
 const char kRebootOnShutdown[] = "cros.device.reboot_on_shutdown";
 
 // An integer pref that specifies the limit of the device's extension cache
 // size in bytes.
 const char kExtensionCacheSize[] = "cros.device.extension_cache_size";
 
 }  // namespace chromeos