Issue 1052593002: Revert of Fix JSON parser Handle leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052593002: Revert of Fix JSON parser Handle leak (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org

Modified:
5 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Fix JSON parser Handle leak (patchset #3 id:40001 of https://codereview.chromium.org/1041483004/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Fix JSON parser Handle leak > > R=verwaest@chromium.org > BUG=v8:3976 > LOG=y > > Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa > Cr-Commit-Position: refs/heads/master@{#27512} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3976 Committed: https://crrev.com/77dd1f347d736abf73a25993c255515728139f2c Cr-Commit-Position: refs/heads/master@{#27562}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -154 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap/heap.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap/heap.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	src/json-parser.h	View	4 chunks	+94 lines, -131 lines	0 comments	Download
M	test/mjsunit/regress/regress-3976.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Erik Corry Chromium.org

Created Revert of Fix JSON parser Handle leak

5 years, 8 months ago (2015-04-01 09:22:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052593002/1

5 years, 8 months ago (2015-04-01 09:22:49 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 09:23:10 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/77dd1f347d736abf73a25993c255515728139f2c
Cr-Commit-Position: refs/heads/master@{#27562}