Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1041483004: Fix JSON parser Handle leak (Closed)

Created:
5 years, 9 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSON parser Handle leak R=verwaest@chromium.org BUG=v8:3976 LOG=y Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa Cr-Commit-Position: refs/heads/master@{#27512}

Patch Set 1 #

Patch Set 2 : Add test, fix debug mode #

Patch Set 3 : Fix int width issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -84 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M src/json-parser.h View 1 4 chunks +120 lines, -83 lines 0 comments Download
M test/mjsunit/regress/regress-3976.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
Erik Corry Chromium.org
5 years, 9 months ago (2015-03-27 13:37:27 UTC) #1
Erik Corry Chromium.org
Rietveld isn't very good at indentation changes. What's happened here is that I've divided up ...
5 years, 9 months ago (2015-03-27 13:40:32 UTC) #2
Erik Corry Chromium.org
Performance numbers for Kraken look neutral. There's a regression on json-stringify-tinderbox on one platform, but ...
5 years, 9 months ago (2015-03-27 13:59:38 UTC) #3
Erik Corry Chromium.org
On 2015/03/27 13:59:38, Erik Corry Chromium.org wrote: > Performance numbers for Kraken look neutral. There's ...
5 years, 9 months ago (2015-03-27 14:15:34 UTC) #4
Toon Verwaest
lgtm
5 years, 8 months ago (2015-03-30 08:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041483004/20001
5 years, 8 months ago (2015-03-30 08:37:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3380)
5 years, 8 months ago (2015-03-30 08:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041483004/20001
5 years, 8 months ago (2015-03-30 09:00:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3384)
5 years, 8 months ago (2015-03-30 09:14:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041483004/40001
5 years, 8 months ago (2015-03-30 09:32:03 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-30 09:55:22 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa Cr-Commit-Position: refs/heads/master@{#27512}
5 years, 8 months ago (2015-03-30 09:55:42 UTC) #18
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-01 09:22:27 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1052593002/ by erikcorry@chromium.org.

The reason for reverting is: Reverting due to JSOn parser failures.

Powered by Google App Engine
This is Rietveld 408576698