Source/bindings/scripts/v8_interface.py - Issue 1052563002: [bindings] Include V8HiddenValue only if attribute has CachedAttribute or marked keep alive for GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 1052563002: [bindings] Include V8HiddenValue only if attribute has CachedAttribute or marked keep alive for GC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 729ef45b3f83ee53795a46010121b3dc63d1b46b..0e0345804c4155ce0283a6e20b931d2add2b45f6 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -62,7 +62,6 @@ INTERFACE_H_INCLUDES = frozenset([

INTERFACE_CPP_INCLUDES = frozenset([

'bindings/core/v8/ExceptionState.h',

'bindings/core/v8/V8DOMConfiguration.h',

- 'bindings/core/v8/V8HiddenValue.h',

'bindings/core/v8/V8ObjectConstructor.h',

'core/dom/ContextFeatures.h',

'core/dom/Document.h',

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/core/V8ArrayBuffer.cpp » ('j') | no next file with comments »