Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: Source/bindings/scripts/v8_interface.py

Issue 1052563002: [bindings] Include V8HiddenValue only if attribute has CachedAttribute or marked keep alive for GC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # coding=utf-8 2 # coding=utf-8
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 'bindings/core/v8/ScriptWrappable.h', 55 'bindings/core/v8/ScriptWrappable.h',
56 'bindings/core/v8/ToV8.h', 56 'bindings/core/v8/ToV8.h',
57 'bindings/core/v8/V8Binding.h', 57 'bindings/core/v8/V8Binding.h',
58 'bindings/core/v8/V8DOMWrapper.h', 58 'bindings/core/v8/V8DOMWrapper.h',
59 'bindings/core/v8/WrapperTypeInfo.h', 59 'bindings/core/v8/WrapperTypeInfo.h',
60 'platform/heap/Handle.h', 60 'platform/heap/Handle.h',
61 ]) 61 ])
62 INTERFACE_CPP_INCLUDES = frozenset([ 62 INTERFACE_CPP_INCLUDES = frozenset([
63 'bindings/core/v8/ExceptionState.h', 63 'bindings/core/v8/ExceptionState.h',
64 'bindings/core/v8/V8DOMConfiguration.h', 64 'bindings/core/v8/V8DOMConfiguration.h',
65 'bindings/core/v8/V8HiddenValue.h',
66 'bindings/core/v8/V8ObjectConstructor.h', 65 'bindings/core/v8/V8ObjectConstructor.h',
67 'core/dom/ContextFeatures.h', 66 'core/dom/ContextFeatures.h',
68 'core/dom/Document.h', 67 'core/dom/Document.h',
69 'platform/RuntimeEnabledFeatures.h', 68 'platform/RuntimeEnabledFeatures.h',
70 'platform/TraceEvent.h', 69 'platform/TraceEvent.h',
71 'wtf/GetPtr.h', 70 'wtf/GetPtr.h',
72 'wtf/RefPtr.h', 71 'wtf/RefPtr.h',
73 ]) 72 ])
74 73
75 74
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 1330
1332 idl_type = deleter.idl_type 1331 idl_type = deleter.idl_type
1333 extended_attributes = deleter.extended_attributes 1332 extended_attributes = deleter.extended_attributes
1334 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState') 1333 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState')
1335 return { 1334 return {
1336 'is_call_with_script_state': is_call_with_script_state, 1335 'is_call_with_script_state': is_call_with_script_state,
1337 'is_custom': 'Custom' in extended_attributes, 1336 'is_custom': 'Custom' in extended_attributes,
1338 'is_raises_exception': 'RaisesException' in extended_attributes, 1337 'is_raises_exception': 'RaisesException' in extended_attributes,
1339 'name': cpp_name(deleter), 1338 'name': cpp_name(deleter),
1340 } 1339 }
OLDNEW
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/core/V8ArrayBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698