Issue 1052523005: ServiceWorker: Remove Clients.getAll()

Issue 1052523005: ServiceWorker: Remove Clients.getAll() (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto

Modified:
5 years, 8 months ago

Reviewers:
kinuko

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Remove Clients.getAll() Intent to rename thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h8hBAkca8NE BUG=451334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193000

Patch Set 1 : #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/modules/serviceworkers/Clients.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052523005/20001

5 years, 8 months ago (2015-04-02 05:54:16 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193000

5 years, 8 months ago (2015-04-02 05:58:20 UTC) #7

Justin Novosad

5 years, 8 months ago (2015-04-02 13:59:07 UTC) #8

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1057893002/ by junov@chromium.org.

The reason for reverting is: This is causing browser test failures:
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/9247...

getAll() is still used in tests that live in the chromium repository. Right
here: src/chrome/test/data/push_messaging/service_worker.js.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages