Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052403003: Add missing SystemConfiguration.framework to sync (Closed)

Created:
5 years, 8 months ago by Jiang Jiang
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing SystemConfiguration.framework to sync Mac gn debug build fail because of it: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio This only happens to debug builds because debug uses component build I suppose. As a result, the frameworks linked in the components that sync depends on is not automatically linked into sync, thus revealing the issue.

Patch Set 1 #

Patch Set 2 : Add comment on why this is required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M sync/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sync/sync.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jiang Jiang
5 years, 8 months ago (2015-04-14 16:54:23 UTC) #2 
Nico, do you want to review this or should I forward it to someone working on
sync?

Powered by Google App Engine
This is Rietveld 408576698