sync/BUILD.gn - Issue 1052403003: Add missing SystemConfiguration.framework to sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/BUILD.gn

Issue 1052403003: Add missing SystemConfiguration.framework to sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment on why this is required Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/BUILD.gn

diff --git a/sync/BUILD.gn b/sync/BUILD.gn

index 6e567e0fc6fc5065327016d9c2d205517ea4a392..6d0a7079613f37eac084ff79bef3359f4889f6a3 100644

--- a/sync/BUILD.gn

+++ b/sync/BUILD.gn

@@ -421,6 +421,13 @@ source_set("sync_core") {

deps += [ "//chromeos" ]

}

+ if (is_mac) {

+ libs = [

+ # Required by get_session_name_mac.mm on Mac.

+ "SystemConfiguration.framework",

+ ]

+ }

defines = [ "SYNC_IMPLEMENTATION" ]

configs += [ "//build/config/compiler:wexit_time_destructors" ]

}

« no previous file with comments | « no previous file | sync/sync.gyp » ('j') | no next file with comments »