Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gyp/configurations.gypi

Issue 105223002: Simplifies standalone VM Android build. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/build.py ('K') | « tools/build.py ('k') | tools/gyp/configurations_android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/configurations.gypi
===================================================================
--- tools/gyp/configurations.gypi (revision 31074)
+++ tools/gyp/configurations.gypi (working copy)
@@ -13,20 +13,25 @@
# Default value. This may be overridden in a containing project gyp.
'target_arch%': 'ia32',
- 'conditions': [
- ['"<(target_arch)"=="ia32"', { 'dart_target_arch': 'IA32', }],
- ['"<(target_arch)"=="x64"', { 'dart_target_arch': 'X64', }],
- ['"<(target_arch)"=="arm"', { 'dart_target_arch': 'ARM', }],
- ['"<(target_arch)"=="simarm"', { 'dart_target_arch': 'SIMARM', }],
- ['"<(target_arch)"=="mips"', { 'dart_target_arch': 'MIPS', }],
- ['"<(target_arch)"=="simmips"', { 'dart_target_arch': 'SIMMIPS', }],
- ],
+ 'conditions': [
+ ['"<(target_arch)"=="ia32"', { 'dart_target_arch': 'IA32', }],
+ ['"<(target_arch)"=="x64"', { 'dart_target_arch': 'X64', }],
+ ['"<(target_arch)"=="arm"', { 'dart_target_arch': 'ARM', }],
+ ['"<(target_arch)"=="simarm"', { 'dart_target_arch': 'SIMARM', }],
+ ['"<(target_arch)"=="mips"', { 'dart_target_arch': 'MIPS', }],
+ ['"<(target_arch)"=="simmips"', { 'dart_target_arch': 'SIMMIPS', }],
+ [ 'OS=="linux"', { 'dart_target_os': 'Linux', } ],
+ [ 'OS=="mac"', { 'dart_target_os': 'Macos', } ],
+ [ 'OS=="win"', { 'dart_target_os': 'Win', } ],
+ [ 'OS=="android"', { 'chrome_target_os': 'Android',},
Ivan Posva 2013/12/20 06:53:47 Why are you setting chrome_target_os here, while a
zra 2013/12/20 16:09:48 Added clarifying comment. The 'line below' is the
+ { 'chrome_target_os': '',}],
+ ],
},
- 'conditions': [
- [ 'OS=="android"', { 'includes': [ 'configurations_android.gypi', ], } ],
- [ 'OS=="linux"', { 'includes': [ 'configurations_make.gypi', ], } ],
- [ 'OS=="mac"', { 'includes': [ 'configurations_xcode.gypi', ], } ],
- [ 'OS=="win"', { 'includes': [ 'configurations_msvs.gypi', ], } ],
+ 'includes': [
+ 'configurations_android.gypi',
+ 'configurations_make.gypi',
+ 'configurations_xcode.gypi',
+ 'configurations_msvs.gypi',
],
'target_defaults': {
'default_configuration': 'DebugIA32',
@@ -82,68 +87,156 @@
],
},
+
+ # Configurations
'DebugIA32': {
- 'inherit_from': ['Dart_Base', 'Dart_ia32_Base', 'Dart_Debug'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_ia32_Base', 'Dart_Debug',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_ia32_Base',
+ 'Dart_<(dart_target_os)_Debug',],
},
'ReleaseIA32': {
- 'inherit_from': ['Dart_Base', 'Dart_ia32_Base', 'Dart_Release'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_ia32_Base', 'Dart_Release',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_ia32_Base',
+ 'Dart_<(dart_target_os)_Release',],
},
'DebugX64': {
- 'inherit_from': ['Dart_Base', 'Dart_x64_Base', 'Dart_Debug'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_x64_Base', 'Dart_Debug',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_x64_Base',
+ 'Dart_<(dart_target_os)_Debug',],
},
'ReleaseX64': {
- 'inherit_from': ['Dart_Base', 'Dart_x64_Base', 'Dart_Release'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_x64_Base', 'Dart_Release',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_x64_Base',
+ 'Dart_<(dart_target_os)_Release',],
},
'DebugSIMARM': {
- 'inherit_from': ['Dart_Base', 'Dart_simarm_Base', 'Dart_Debug'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_simarm_Base', 'Dart_Debug',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_simarm_Base',
+ 'Dart_<(dart_target_os)_Debug',],
'defines': [
'DEBUG',
],
},
'ReleaseSIMARM': {
- 'inherit_from': ['Dart_Base', 'Dart_simarm_Base', 'Dart_Release'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_simarm_Base', 'Dart_Release',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_simarm_Base',
+ 'Dart_<(dart_target_os)_Release',],
},
- 'DebugARM': {
- 'inherit_from': ['Dart_Base', 'Dart_arm_Base', 'Dart_Debug'],
- },
-
- 'ReleaseARM': {
- 'inherit_from': ['Dart_Base', 'Dart_arm_Base', 'Dart_Release'],
- },
-
'DebugSIMMIPS': {
- 'inherit_from': ['Dart_Base', 'Dart_simmips_Base', 'Dart_Debug'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_simmips_Base', 'Dart_Debug',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_simmips_Base',
+ 'Dart_<(dart_target_os)_Debug',],
'defines': [
'DEBUG',
],
},
'ReleaseSIMMIPS': {
- 'inherit_from': ['Dart_Base', 'Dart_simmips_Base', 'Dart_Release'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_simmips_Base', 'Dart_Release',
+ 'Dart_<(dart_target_os)_Base',
+ 'Dart_<(dart_target_os)_simmips_Base',
+ 'Dart_<(dart_target_os)_Release',],
},
+
+ # ARM and MIPS hardware configurations are only for Linux and Android.
+ 'DebugARM': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_arm_Base', 'Dart_Debug',
+ 'Dart_Linux_Base',
+ 'Dart_Linux_arm_Base',
+ 'Dart_Linux_Debug',],
+ },
+
+ 'ReleaseARM': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_arm_Base', 'Dart_Release',
+ 'Dart_Linux_Base',
+ 'Dart_Linux_arm_Base',
+ 'Dart_Linux_Release',],
+ },
+
'DebugMIPS': {
- 'inherit_from': ['Dart_Base', 'Dart_mips_Base', 'Dart_Debug'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_mips_Base', 'Dart_Debug',
+ 'Dart_Linux_Base',
+ 'Dart_Linux_mips_Base',
+ 'Dart_Linux_Debug',],
},
'ReleaseMIPS': {
- 'inherit_from': ['Dart_Base', 'Dart_mips_Base', 'Dart_Release'],
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_mips_Base', 'Dart_Release',
+ 'Dart_Linux_Base',
+ 'Dart_Linux_mips_Base',
+ 'Dart_Linux_Release',],
},
+ # Android configurations. The configuration names explicitly include
+ # 'Android' because we are cross-building from Linux, and cannot inspect
+ # the gyp builtin 'OS' variable to figure out that we are building for
+ # Android; since we have not re-run gyp, it will still be 'linux'.
+ 'DebugAndroidIA32': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_ia32_Base', 'Dart_Debug',
+ 'Dart_Android_Base',
+ 'Dart_Android_ia32_Base',
+ 'Dart_Android_Debug',],
+ },
+
+ 'ReleaseAndroidIA32': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_ia32_Base', 'Dart_Release',
+ 'Dart_Android_Base',
+ 'Dart_Android_ia32_Base',
+ 'Dart_Android_Release',],
+ },
+
+ 'DebugAndroidARM': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_arm_Base', 'Dart_Debug',
+ 'Dart_Android_Base',
+ 'Dart_Android_arm_Base',
+ 'Dart_Android_Debug',],
+ },
+
+ 'ReleaseAndroidARM': {
+ 'inherit_from': [
+ 'Dart_Base', 'Dart_arm_Base', 'Dart_Release',
+ 'Dart_Android_Base',
+ 'Dart_Android_arm_Base',
+ 'Dart_Android_Release',],
+ },
+
# These targets assume that target_arch is passed in explicitly
# by the containing project (e.g., chromium).
'Debug': {
- 'inherit_from': ['Debug<(dart_target_arch)']
+ 'inherit_from': ['Debug<(chrome_target_os)<(dart_target_arch)']
},
'Release': {
- 'inherit_from': ['Release<(dart_target_arch)']
+ 'inherit_from': ['Release<(chrome_target_os)<(dart_target_arch)']
},
},
},
« tools/build.py ('K') | « tools/build.py ('k') | tools/gyp/configurations_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698