Simplifies standalone VM Android build.

tools/gyp/configurations.gypi

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'common_gcc_warning_flags': [
       '-Wall',
       '-Wextra', # Also known as -W.
       '-Wno-unused-parameter',
     ],
 
     # Default value.  This may be overridden in a containing project gyp.
     'target_arch%': 'ia32',
 
-  'conditions': [
-    ['"<(target_arch)"=="ia32"', { 'dart_target_arch': 'IA32', }],
-    ['"<(target_arch)"=="x64"', { 'dart_target_arch': 'X64', }],
-    ['"<(target_arch)"=="arm"', { 'dart_target_arch': 'ARM', }],
-    ['"<(target_arch)"=="simarm"', { 'dart_target_arch': 'SIMARM', }],
-    ['"<(target_arch)"=="mips"', { 'dart_target_arch': 'MIPS', }],
-    ['"<(target_arch)"=="simmips"', { 'dart_target_arch': 'SIMMIPS', }],
-  ],
+    'conditions': [
+      ['"<(target_arch)"=="ia32"', { 'dart_target_arch': 'IA32', }],
+      ['"<(target_arch)"=="x64"', { 'dart_target_arch': 'X64', }],
+      ['"<(target_arch)"=="arm"', { 'dart_target_arch': 'ARM', }],
+      ['"<(target_arch)"=="simarm"', { 'dart_target_arch': 'SIMARM', }],
+      ['"<(target_arch)"=="mips"', { 'dart_target_arch': 'MIPS', }],
+      ['"<(target_arch)"=="simmips"', { 'dart_target_arch': 'SIMMIPS', }],
+      [ 'OS=="linux"', { 'dart_target_os': 'Linux', } ],
+      [ 'OS=="mac"', { 'dart_target_os': 'Macos', } ],
+      [ 'OS=="win"', { 'dart_target_os': 'Win', } ],
+      [ 'OS=="android"', { 'chrome_target_os': 'Android',},

[Ivan Posva, 2013/12/20 06:53:47]

Why are you setting chrome_target_os here, while all the others are setting
dart_target_os? Also why is the chrome_target_os property overridden immediately
on the line below. At least some comment explaining the reasoning would be
helpful.

[zra, 2013/12/20 16:09:48]

Added clarifying comment. The 'line below' is the else branch of the
'OS=="android"' condition.

+                         { 'chrome_target_os': '',}],
+    ],
   },
-  'conditions': [
-    [ 'OS=="android"', { 'includes': [ 'configurations_android.gypi', ], } ],
-    [ 'OS=="linux"', { 'includes': [ 'configurations_make.gypi', ], } ],
-    [ 'OS=="mac"', { 'includes': [ 'configurations_xcode.gypi', ], } ],
-    [ 'OS=="win"', { 'includes': [ 'configurations_msvs.gypi', ], } ],
+  'includes': [
+    'configurations_android.gypi',
+    'configurations_make.gypi',
+    'configurations_xcode.gypi',
+    'configurations_msvs.gypi',
   ],
   'target_defaults': {
     'default_configuration': 'DebugIA32',
     'configurations': {
       'Dart_Base': {
         'abstract': 1,
       },
 
       'Dart_ia32_Base': {
         'abstract': 1,
@@ skipping 35 matching lines @@
         'abstract': 1,
       },
 
       'Dart_Release': {
         'abstract': 1,
         'defines': [
           'NDEBUG',
         ],
       },
 
+
+      # Configurations
       'DebugIA32': {
-        'inherit_from': ['Dart_Base', 'Dart_ia32_Base', 'Dart_Debug'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_ia32_Base', 'Dart_Debug',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_ia32_Base',
+            'Dart_<(dart_target_os)_Debug',],
       },
 
       'ReleaseIA32': {
-        'inherit_from': ['Dart_Base', 'Dart_ia32_Base', 'Dart_Release'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_ia32_Base', 'Dart_Release',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_ia32_Base',
+            'Dart_<(dart_target_os)_Release',],
       },
 
       'DebugX64': {
-        'inherit_from': ['Dart_Base', 'Dart_x64_Base', 'Dart_Debug'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_x64_Base', 'Dart_Debug',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_x64_Base',
+            'Dart_<(dart_target_os)_Debug',],
       },
 
       'ReleaseX64': {
-        'inherit_from': ['Dart_Base', 'Dart_x64_Base', 'Dart_Release'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_x64_Base', 'Dart_Release',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_x64_Base',
+            'Dart_<(dart_target_os)_Release',],
       },
 
       'DebugSIMARM': {
-        'inherit_from': ['Dart_Base', 'Dart_simarm_Base', 'Dart_Debug'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_simarm_Base', 'Dart_Debug',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_simarm_Base',
+            'Dart_<(dart_target_os)_Debug',],
         'defines': [
           'DEBUG',
         ],
       },
 
       'ReleaseSIMARM': {
-        'inherit_from': ['Dart_Base', 'Dart_simarm_Base', 'Dart_Release'],
-      },
-
-      'DebugARM': {
-        'inherit_from': ['Dart_Base', 'Dart_arm_Base', 'Dart_Debug'],
-      },
-
-      'ReleaseARM': {
-        'inherit_from': ['Dart_Base', 'Dart_arm_Base', 'Dart_Release'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_simarm_Base', 'Dart_Release',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_simarm_Base',
+            'Dart_<(dart_target_os)_Release',],
       },
 
       'DebugSIMMIPS': {
-        'inherit_from': ['Dart_Base', 'Dart_simmips_Base', 'Dart_Debug'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_simmips_Base', 'Dart_Debug',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_simmips_Base',
+            'Dart_<(dart_target_os)_Debug',],
         'defines': [
           'DEBUG',
         ],
       },
 
       'ReleaseSIMMIPS': {
-        'inherit_from': ['Dart_Base', 'Dart_simmips_Base', 'Dart_Release'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_simmips_Base', 'Dart_Release',
+            'Dart_<(dart_target_os)_Base',
+            'Dart_<(dart_target_os)_simmips_Base',
+            'Dart_<(dart_target_os)_Release',],
+      },
+
+
+      # ARM and MIPS hardware configurations are only for Linux and Android.
+      'DebugARM': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_arm_Base', 'Dart_Debug',
+            'Dart_Linux_Base',
+            'Dart_Linux_arm_Base',
+            'Dart_Linux_Debug',],
+      },
+
+      'ReleaseARM': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_arm_Base', 'Dart_Release',
+            'Dart_Linux_Base',
+            'Dart_Linux_arm_Base',
+            'Dart_Linux_Release',],
       },
 
       'DebugMIPS': {
-        'inherit_from': ['Dart_Base', 'Dart_mips_Base', 'Dart_Debug'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_mips_Base', 'Dart_Debug',
+            'Dart_Linux_Base',
+            'Dart_Linux_mips_Base',
+            'Dart_Linux_Debug',],
       },
 
       'ReleaseMIPS': {
-        'inherit_from': ['Dart_Base', 'Dart_mips_Base', 'Dart_Release'],
+        'inherit_from': [
+            'Dart_Base', 'Dart_mips_Base', 'Dart_Release',
+            'Dart_Linux_Base',
+            'Dart_Linux_mips_Base',
+            'Dart_Linux_Release',],
+      },
+
+      # Android configurations. The configuration names explicitly include
+      # 'Android' because we are cross-building from Linux, and cannot inspect
+      # the gyp builtin 'OS' variable to figure out that we are building for
+      # Android; since we have not re-run gyp, it will still be 'linux'.
+      'DebugAndroidIA32': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_ia32_Base', 'Dart_Debug',
+            'Dart_Android_Base',
+            'Dart_Android_ia32_Base',
+            'Dart_Android_Debug',],
+      },
+
+      'ReleaseAndroidIA32': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_ia32_Base', 'Dart_Release',
+            'Dart_Android_Base',
+            'Dart_Android_ia32_Base',
+            'Dart_Android_Release',],
+      },
+
+      'DebugAndroidARM': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_arm_Base', 'Dart_Debug',
+            'Dart_Android_Base',
+            'Dart_Android_arm_Base',
+            'Dart_Android_Debug',],
+      },
+
+      'ReleaseAndroidARM': {
+        'inherit_from': [
+            'Dart_Base', 'Dart_arm_Base', 'Dart_Release',
+            'Dart_Android_Base',
+            'Dart_Android_arm_Base',
+            'Dart_Android_Release',],
       },
 
       # These targets assume that target_arch is passed in explicitly
       # by the containing project (e.g., chromium).
       'Debug': {
-        'inherit_from': ['Debug<(dart_target_arch)']
+        'inherit_from': ['Debug<(chrome_target_os)<(dart_target_arch)']
       },
 
       'Release': {
-        'inherit_from': ['Release<(dart_target_arch)']
+        'inherit_from': ['Release<(chrome_target_os)<(dart_target_arch)']
       },
     },
   },
 }