Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1052143002: Remove FixSubversionConfig from run_slave.py (Closed)

Created:
5 years, 8 months ago by hinoka
Modified:
5 years, 8 months ago
Reviewers:
dnj, M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove FixSubversionConfig from run_slave.py We no longer use SVN, and this is causing issues on slaves without SVN installed. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294655

Patch Set 1 #

Patch Set 2 : Remove SVN config file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
D slave/config View 1 1 chunk +0 lines, -50 lines 0 comments Download
M slave/run_slave.py View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hinoka
Last thing needed to get windows buildbots running!
5 years, 8 months ago (2015-04-02 02:28:53 UTC) #2
dnj
Wow, that's terrifying. This references a "config" file: https://chromium.googlesource.com/chromium/tools/build/+/master/slave/config Since we're not using it anymore, ...
5 years, 8 months ago (2015-04-02 03:24:36 UTC) #3
hinoka
Good idea, removing config file
5 years, 8 months ago (2015-04-02 04:08:34 UTC) #4
M-A Ruel
lgtm, good riddance.
5 years, 8 months ago (2015-04-02 13:55:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052143002/20001
5 years, 8 months ago (2015-04-02 13:56:25 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 14:04:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294655

Powered by Google App Engine
This is Rietveld 408576698