Make test proxy Platform objects provide currentThread().

Make test proxy Platform objects provide currentThread().

For the benefit of the Oilpan GC and it needing to post tasks, have
these two test Platform objects provide a delegating currentThread()
implementation.

R=haraken,skyostil
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195923

[sof, 2015-04-24 10:31:24]

sigbjornf@opera.com changed reviewers:
+ dstockwell@chromium.org, haraken@chromium.org, loyso@chromium.org,
mithro@mithis.com

[sof, 2015-04-24 10:31:24]

Please take a look.

[loyso (OOO), 2015-04-27 00:26:40]

On 2015/04/24 10:31:24, sof wrote:
> Please take a look.

Looks very good.

[haraken, 2015-04-27 00:57:13]

(I want to defer this review to threading experts.)

[sof, 2015-04-28 08:10:15]

On 2015/04/27 00:57:13, haraken wrote:
> (I want to defer this review to threading experts.)

Beyond the esteemed set of folks on the reviewer list, anyone else you think
it'd be worth looping in?

[sof, 2015-05-19 06:21:17]

sigbjornf@opera.com changed reviewers:
+ alexclarke@chromium.org, jochen@chromium.org, skyostil@chromium.org

[sof, 2015-05-19 06:21:17]

+ some thread/platform champions :) -- does extending these test blink::Platform
implementations with a delegating currentThread() implementation appear
acceptable to you?

(Backstory: should any of the tests here trigger the scheduling of a GC task, we
want to ensure there's a currentThread() in Oilpan to do that via.)

[Sami, 2015-05-19 10:41:44]

On 2015/05/19 06:21:17, sof wrote:
> + some thread/platform champions :) -- does extending these test
blink::Platform
> implementations with a delegating currentThread() implementation appear
> acceptable to you?
> 
> (Backstory: should any of the tests here trigger the scheduling of a GC task,
we
> want to ensure there's a currentThread() in Oilpan to do that via.)

This looks fine to me and is similar to what we've been doing in other tests
(e.g., https://codereview.chromium.org/1134523002/). It'd be great if Blink code
can always just assume it can access the current thread via the platform.

[Sami, 2015-05-19 10:41:51]

https://codereview.chromium.org/1052103004/diff/1/Source/core/animation/Compo...
File Source/core/animation/CompositorAnimationsTestHelper.h (right):

https://codereview.chromium.org/1052103004/diff/1/Source/core/animation/Compo...
Source/core/animation/CompositorAnimationsTestHelper.h:165: if (m_platform)
Will this ever be null?

[sof, 2015-05-19 16:12:07]

thanks, tidied this CL, but i'll let https://codereview.chromium.org/1134523002/
take care of landing the changes here.

https://codereview.chromium.org/1052103004/diff/1/Source/core/animation/Compo...
File Source/core/animation/CompositorAnimationsTestHelper.h (right):

https://codereview.chromium.org/1052103004/diff/1/Source/core/animation/Compo...
Source/core/animation/CompositorAnimationsTestHelper.h:165: if (m_platform)
On 2015/05/19 10:41:51, Sami wrote:
> Will this ever be null?

We can safely assume that it won't be; thanks, removed the check(s).

[Sami, 2015-05-20 15:23:27]

Great, non-owner lgtm.

[haraken, 2015-05-20 22:57:40]

LGTM

[sof, 2015-05-26 21:26:35]

The keenly awaited https://codereview.chromium.org/1134523002/ , which includes
the changes herein, is taking a bit longer to land.

As webkit unit tests have started to fail due to a lack currentThread() in
animation tests wanting to schedule a GC,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%...

I'm going to go ahead and land this CL so as to address. My apologies for the
extra rebase most likely required on https://codereview.chromium.org/1134523002/
as a result.

[sof, 2015-05-26 21:26:42]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-05-26 21:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1052103004/#ps40001
(title: "Code formatting only")

[commit-bot: I haz the power, 2015-05-26 21:27:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052103004/40001

[commit-bot: I haz the power, 2015-05-26 21:31:40]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195923

[Sami, 2015-05-27 11:18:56]

On 2015/05/26 21:26:35, sof wrote:
> The keenly awaited https://codereview.chromium.org/1134523002/ , which
includes
> the changes herein, is taking a bit longer to land.
> 
> As webkit unit tests have started to fail due to a lack currentThread() in
> animation tests wanting to schedule a GC,
> 
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%...
> 
> I'm going to go ahead and land this CL so as to address. My apologies for the
> extra rebase most likely required on
https://codereview.chromium.org/1134523002/
> as a result.

No worries -- thanks for the heads-up!