Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: Source/core/animation/CompositorAnimationsTestHelper.h

Issue 1052103004: Make test proxy Platform objects provide currentThread(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code formatting only Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/fetch/CachingCorrectnessTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/CompositorAnimationsTestHelper.h
diff --git a/Source/core/animation/CompositorAnimationsTestHelper.h b/Source/core/animation/CompositorAnimationsTestHelper.h
index 31c0f09ab9561789275e1dfd63b48e9da0ed98b2..8f70be0b4cb0b909b2feb325e5dc826487b1147a 100644
--- a/Source/core/animation/CompositorAnimationsTestHelper.h
+++ b/Source/core/animation/CompositorAnimationsTestHelper.h
@@ -142,7 +142,12 @@ public:
private:
class PlatformProxy : public Platform {
public:
- PlatformProxy(WebCompositorSupportMock** compositor) : m_compositor(compositor) { }
+ PlatformProxy(WebCompositorSupportMock** compositor) : m_platform(Platform::current()), m_compositor(compositor) { }
+
+ ~PlatformProxy()
+ {
+ blink::Platform::initialize(m_platform);
+ }
virtual void cryptographicallyRandomValues(unsigned char* buffer, size_t length) { ASSERT_NOT_REACHED(); }
const unsigned char* getTraceCategoryEnabledFlag(const char* categoryName) override
@@ -151,7 +156,13 @@ private:
return &tracingIsDisabled;
}
+ WebThread* currentThread() override
+ {
+ return m_platform->currentThread();
+ }
+
private:
+ blink::Platform* m_platform; // Not owned.
WebCompositorSupportMock** m_compositor;
virtual WebCompositorSupport* compositorSupport() override { return *m_compositor; }
};
@@ -160,20 +171,12 @@ private:
PlatformProxy m_proxyPlatform;
protected:
- Platform* m_platform;
-
virtual void SetUp()
{
m_mockCompositor = 0;
- m_platform = Platform::current();
Platform::initialize(&m_proxyPlatform);
}
- virtual void TearDown()
- {
- Platform::initialize(m_platform);
- }
-
void setCompositorForTesting(WebCompositorSupportMock& mock)
{
ASSERT(!m_mockCompositor);
« no previous file with comments | « no previous file | Source/core/fetch/CachingCorrectnessTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698