bluetooth: Stub out BluetoothGattRemoteServer.

bluetooth: Stub out BluetoothGattRemoteServer.

BUG=476735
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193828

[ortuno, 2015-04-13 23:28:03]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org, scheib@chromium.org

[ortuno, 2015-04-14 00:42:53]

Please review @scheib & @jyasskin

[Jeffrey Yasskin, 2015-04-14 01:39:23]

I don't know enough about Blink modules to be a great reviewer, but other than
the 2 comments below, lgtm.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:16: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
Can we avoid finalization here? BluetoothDevice.gattServer will keep this object
alive as long as the BluetoothDevice is alive, so we only need to have
finalization on 1 piece of the whole graph in order to let the Browser know that
this renderer doesn't need the device anymore.

Then again, the Oilpan doc says to use finalization when in doubt, and I don't
know that we'll avoid all C++ objects in the members here.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.idl (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.idl:7: // Implement
BluetoothGATTRemoteServer interface: https://crbug.com/476735
I'm skeptical of the bug reference here. I don't think it's really useful for
folks reading the file, and it doesn't seem to be a convention followed in the
couple other modules I just checked. The spec reference is great.

[scheib, 2015-04-14 18:25:42]

LGTM, though remove finalized.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:16: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> Can we avoid finalization here? BluetoothDevice.gattServer will keep this
object
> alive as long as the BluetoothDevice is alive, so we only need to have
> finalization on 1 piece of the whole graph in order to let the Browser know
that
> this renderer doesn't need the device anymore.
> 
> Then again, the Oilpan doc says to use finalization when in doubt, and I don't
> know that we'll avoid all C++ objects in the members here.

Drop Finalized until/unless we need it.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.idl (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.idl:7: // Implement
BluetoothGATTRemoteServer interface: https://crbug.com/476735
On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> I'm skeptical of the bug reference here. I don't think it's really useful for
> folks reading the file, and it doesn't seem to be a convention followed in the
> couple other modules I just checked. The spec reference is great.

Spec reference is style guide.

Bug reference is a pattern I follow for incomplete code because it makes sense
to me to point directly to the issue where any discussion or status of
implementation can be seen. I'd like to use it in this module.

[ortuno, 2015-04-14 19:31:20]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-14 19:31:20]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-14 19:31:21]

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:16: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
On 2015/04/14 at 18:25:42, scheib wrote:
> On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> > Can we avoid finalization here? BluetoothDevice.gattServer will keep this
object
> > alive as long as the BluetoothDevice is alive, so we only need to have
> > finalization on 1 piece of the whole graph in order to let the Browser know
that
> > this renderer doesn't need the device anymore.
> > 
> > Then again, the Oilpan doc says to use finalization when in doubt, and I
don't
> > know that we'll avoid all C++ objects in the members here.
> 
> Drop Finalized until/unless we need it.

Done.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.idl (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.idl:7: // Implement
BluetoothGATTRemoteServer interface: https://crbug.com/476735
On 2015/04/14 at 18:25:42, scheib wrote:
> On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> > I'm skeptical of the bug reference here. I don't think it's really useful
for
> > folks reading the file, and it doesn't seem to be a convention followed in
the
> > couple other modules I just checked. The spec reference is great.
> 
> Spec reference is style guide.
> 
> Bug reference is a pattern I follow for incomplete code because it makes sense
to me to point directly to the issue where any discussion or status of
implementation can be seen. I'd like to use it in this module.

Ack.

[ortuno, 2015-04-14 19:31:21]

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:16: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
On 2015/04/14 at 18:25:42, scheib wrote:
> On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> > Can we avoid finalization here? BluetoothDevice.gattServer will keep this
object
> > alive as long as the BluetoothDevice is alive, so we only need to have
> > finalization on 1 piece of the whole graph in order to let the Browser know
that
> > this renderer doesn't need the device anymore.
> > 
> > Then again, the Oilpan doc says to use finalization when in doubt, and I
don't
> > know that we'll avoid all C++ objects in the members here.
> 
> Drop Finalized until/unless we need it.

Done.

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.idl (right):

https://codereview.chromium.org/1052023004/diff/1/Source/modules/bluetooth/Bl...
Source/modules/bluetooth/BluetoothGATTRemoteServer.idl:7: // Implement
BluetoothGATTRemoteServer interface: https://crbug.com/476735
On 2015/04/14 at 18:25:42, scheib wrote:
> On 2015/04/14 01:39:22, Jeffrey Yasskin wrote:
> > I'm skeptical of the bug reference here. I don't think it's really useful
for
> > folks reading the file, and it doesn't seem to be a convention followed in
the
> > couple other modules I just checked. The spec reference is great.
> 
> Spec reference is style guide.
> 
> Bug reference is a pattern I follow for incomplete code because it makes sense
to me to point directly to the issue where any discussion or status of
implementation can be seen. I'd like to use it in this module.

Ack.

[ortuno, 2015-04-14 19:31:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1052023004/#ps40001
(title: " ")

[ortuno, 2015-04-14 19:31:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1052023004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-14 19:31:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/40001

[commit-bot: I haz the power, 2015-04-14 23:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 23:57:50]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[ortuno, 2015-04-14 23:59:31]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-04-14 23:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/40001

[commit-bot: I haz the power, 2015-04-15 01:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 01:46:40]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59203)

[ortuno, 2015-04-15 02:45:51]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-04-15 02:46:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/40001

[commit-bot: I haz the power, 2015-04-15 05:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 05:40:02]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[ortuno, 2015-04-15 05:42:18]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-04-15 05:43:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/40001

[commit-bot: I haz the power, 2015-04-15 07:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 07:25:14]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59246)

[ortuno, 2015-04-15 15:06:18]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-04-15 15:06:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/40001

[commit-bot: I haz the power, 2015-04-15 17:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 17:42:23]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[ortuno, 2015-04-15 19:51:55]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-15 19:51:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1052023004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-15 19:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052023004/60001

[commit-bot: I haz the power, 2015-04-15 22:01:07]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193828