Source/modules/bluetooth/BluetoothGATTRemoteServer.h - Issue 1052023004: bluetooth: Stub out BluetoothGattRemoteServer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/bluetooth/BluetoothGATTRemoteServer.h

Issue 1052023004: bluetooth: Stub out BluetoothGattRemoteServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/bluetooth/idl-BluetoothGATTRemoteServer.html ('k') | Source/modules/bluetooth/BluetoothGATTRemoteServer.idl » ('j') | Source/modules/bluetooth/BluetoothGATTRemoteServer.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BluetoothGATTRemoteServer_h

	6 #define BluetoothGATTRemoteServer_h

	7

	8 #include "bindings/core/v8/ScriptWrappable.h"

	9 #include "platform/heap/Heap.h"

	10 #include "wtf/text/WTFString.h"

	11

	12 namespace blink {

	13

	14 // BluetoothGATTRemoteServer provides a way to interact with a connected bluetoo th peripheral.

	15 class BluetoothGATTRemoteServer final

	16 : public GarbageCollectedFinalized<BluetoothGATTRemoteServer>
	Jeffrey Yasskin 2015/04/14 01:39:22 Can we avoid finalization here? BluetoothDevice.ga Can we avoid finalization here? BluetoothDevice.gattServer will keep this object alive as long as the BluetoothDevice is alive, so we only need to have finalization on 1 piece of the whole graph in order to let the Browser know that this renderer doesn't need the device anymore. Then again, the Oilpan doc says to use finalization when in doubt, and I don't know that we'll avoid all C++ objects in the members here. scheib 2015/04/14 18:25:42 Drop Finalized until/unless we need it. Show quoted text On 2015/04/14 01:39:22, Jeffrey Yasskin wrote: > Can we avoid finalization here? BluetoothDevice.gattServer will keep this object > alive as long as the BluetoothDevice is alive, so we only need to have > finalization on 1 piece of the whole graph in order to let the Browser know that > this renderer doesn't need the device anymore. > > Then again, the Oilpan doc says to use finalization when in doubt, and I don't > know that we'll avoid all C++ objects in the members here. Drop Finalized until/unless we need it. ortuno 2015/04/14 19:31:21 Done. Show quoted text On 2015/04/14 at 18:25:42, scheib wrote: > On 2015/04/14 01:39:22, Jeffrey Yasskin wrote: > > Can we avoid finalization here? BluetoothDevice.gattServer will keep this object > > alive as long as the BluetoothDevice is alive, so we only need to have > > finalization on 1 piece of the whole graph in order to let the Browser know that > > this renderer doesn't need the device anymore. > > > > Then again, the Oilpan doc says to use finalization when in doubt, and I don't > > know that we'll avoid all C++ objects in the members here. > > Drop Finalized until/unless we need it. Done.
	17 , public ScriptWrappable {

	18 DEFINE_WRAPPERTYPEINFO();

	19 public:

	20 void trace(Visitor*) { }

	21 };

	22

	23 } // namespace blink

	24

	25 #endif // BluetoothDevice_h

OLD	NEW