Issue 1052002: Move over another legacy "LoadLog-style" event generator to routing its messa...

Issue 1052002: Move over another legacy "LoadLog-style" event generator to routing its messa... (Closed)

Created:
10 years, 9 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move over another legacy "LoadLog-style" event generator to routing its messages through the NetLog. BUG=37421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41768

Patch Set 2 : Address willchan's comments #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -57 lines)			Patch
M	chrome/browser/net/chrome_url_request_context.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/net/passive_log_collector.h	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/net/passive_log_collector.cc	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download
M	chrome/browser/net/resolve_proxy_msg_helper_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/view_net_internals_job_factory.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	net/proxy/proxy_service.h	View		4 chunks	+5 lines, -10 lines	0 comments	Download
M	net/proxy/proxy_service.cc	View		6 chunks	+11 lines, -8 lines	0 comments	Download
M	net/proxy/proxy_service_unittest.cc	View		33 chunks	+44 lines, -33 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_request_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

lgtm http://codereview.chromium.org/1052002/diff/1/9 File chrome/browser/net/passive_log_collector.h (right): http://codereview.chromium.org/1052002/diff/1/9#newcode116 chrome/browser/net/passive_log_collector.h:116: InitProxyResolverTracker() {} A bit anal, but can you ...

10 years, 9 months ago (2010-03-16 19:58:25 UTC) #2

eroman

10 years, 9 months ago (2010-03-16 21:04:33 UTC) #3

http://codereview.chromium.org/1052002/diff/1/9
File chrome/browser/net/passive_log_collector.h (right):

http://codereview.chromium.org/1052002/diff/1/9#newcode116
chrome/browser/net/passive_log_collector.h:116: InitProxyResolverTracker() {}
On 2010/03/16 19:58:25, willchan wrote:
> A bit anal, but can you move the definition to the .cc file?  The inline
> constructor will add code bloat because it inlines the std::vector constructor
> too.

Done.

Expand Messages | Collapse Messages