Chromium Code Reviews
Help | Chromium Project | Sign in
(1167)

Issue 1052002: Move over another legacy "LoadLog-style" event generator to routing its messa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Move over another legacy "LoadLog-style" event generator to routing its messages through the NetLog.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41768

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address willchan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -57 lines) Lint Patch
M chrome/browser/net/chrome_url_request_context.cc View 3 chunks +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/passive_log_collector.h View 1 2 chunks +21 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/passive_log_collector.cc View 1 2 chunks +35 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/net/resolve_proxy_msg_helper_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/net/view_net_internals_job_factory.cc View 2 chunks +6 lines, -2 lines 0 comments 0 errors Download
M net/proxy/proxy_service.h View 4 chunks +5 lines, -10 lines 0 comments 0 errors Download
M net/proxy/proxy_service.cc View 6 chunks +11 lines, -8 lines 0 comments 0 errors Download
M net/proxy/proxy_service_unittest.cc View 33 chunks +44 lines, -33 lines 0 comments 0 errors Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
eroman
4 years, 1 month ago #1
willchan
lgtm http://codereview.chromium.org/1052002/diff/1/9 File chrome/browser/net/passive_log_collector.h (right): http://codereview.chromium.org/1052002/diff/1/9#newcode116 chrome/browser/net/passive_log_collector.h:116: InitProxyResolverTracker() {} A bit anal, but can you ...
4 years, 1 month ago #2
eroman
4 years, 1 month ago #3
http://codereview.chromium.org/1052002/diff/1/9
File chrome/browser/net/passive_log_collector.h (right):

http://codereview.chromium.org/1052002/diff/1/9#newcode116
chrome/browser/net/passive_log_collector.h:116: InitProxyResolverTracker() {}
On 2010/03/16 19:58:25, willchan wrote:
> A bit anal, but can you move the definition to the .cc file?  The inline
> constructor will add code bloat because it inlines the std::vector constructor
> too.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6