Fix crash when running "run_benchmark help run"

Fix crash when running "run_benchmark help run"

This change adds a required dependency to the run_benchmark help command
when updating the command line arg parser. This means we no longer crash
when serving help information for the run command.

BUG=472916

[alancutter (OOO until 2018), 2015-04-02 03:26:34]

alancutter@chromium.org changed reviewers:
+ qyearsley@chromium.org

[alancutter (OOO until 2018), 2015-04-02 03:26:34]

I'm somewhat unhappy about this change but making it nicer seems to be out of
scope of fixing this bug.
Passing in an environment to the commands in an interface breaking way is ugly.
Commands should be instance based instead of static classes so they can be
instantiated with arbitrary parameterisation such as environment but that's just
my opinion.

[qyearsley, 2015-04-02 04:22:52]

qyearsley@chromium.org changed reviewers:
+ dtu@chromium.org

[qyearsley, 2015-04-02 04:24:26]

On 2015/04/02 03:26:34, alancutter wrote:
> I'm somewhat unhappy about this change but making it nicer seems to be out of
> scope of fixing this bug.
> Passing in an environment to the commands in an interface breaking way is
ugly.
> Commands should be instance based instead of static classes so they can be
> instantiated with arbitrary parameterisation such as environment but that's
just
> my opinion.

Looks good to me, but I'm not an OWNER (and I'm not very familiar with these
modules).

Dave, could you review?

[sullivan, 2015-04-02 13:30:27]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[dtu, 2015-04-02 22:01:41]

dtu@chromium.org changed reviewers:
+ eakuefner@chromium.org

[dtu, 2015-04-02 22:01:41]

+eakuefner was working on adding environment to benchmark_runner.

[eakuefner, 2015-04-02 22:35:09]

This is not lgtm -- we're aware of this problem and the right fix is pretty
complicated and long-term.

Alan, can you use run_benchmark run --help instead for now? I'll work on a patch
to just paint over 'help run' so that we invoke 'run --help' instead for the
time being and CC you.

[alancutter (OOO until 2018), 2015-04-07 05:02:32]

On 2015/04/02 at 22:35:09, eakuefner wrote:
> This is not lgtm -- we're aware of this problem and the right fix is pretty
complicated and long-term.
> 
> Alan, can you use run_benchmark run --help instead for now? I'll work on a
patch to just paint over 'help run' so that we invoke 'run --help' instead for
the time being and CC you.

Okay, I see https://codereview.chromium.org/1063443002. Thanks.