Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 1051763004: Convert *.css files to *_style.html files for the following custom elements: date_time_page, setting (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert *.css files to *_style.html files for the following custom elements: date_time_page, settings_drawer, settings_main, settings_menu, settings_page_header, and settings_ui. See http://goo.gl/vIGSCO for more information. BUG=477154 Committed: https://crrev.com/3ba1fe2ec13702f1ebf7294f798f73a158d0578f Cr-Commit-Position: refs/heads/master@{#325353}

Patch Set 1 #

Patch Set 2 : Used relative path. #

Patch Set 3 : Add a lot more files/styles. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -159 lines) Patch
D chrome/browser/resources/settings/date_time_page/date_time_page.css View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/date_time_page/date_time_page_style.html View 1 chunk +16 lines, -0 lines 0 comments Download
D chrome/browser/resources/settings/settings_drawer/settings_drawer.css View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/resources/settings/settings_drawer/settings_drawer.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/settings_drawer/settings_drawer_style.html View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/resources/settings/settings_main/settings_main.css View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/settings_main/settings_main_style.html View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/resources/settings/settings_menu/settings_menu.css View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/settings_menu/settings_menu_style.html View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/resources/settings/settings_page/settings_page_header.css View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_page_header.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/settings_page/settings_page_header_style.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
D chrome/browser/resources/settings/settings_ui/settings_ui.css View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/settings_ui/settings_ui_style.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-15 18:21:43 UTC) #2
michaelpg
These changes are rote and trivial now that we've nailed down the pattern. Could you ...
5 years, 8 months ago (2015-04-15 19:09:13 UTC) #3
Kyle Horimoto
On 2015/04/15 19:09:13, michaelpg wrote: > These changes are rote and trivial now that we've ...
5 years, 8 months ago (2015-04-15 22:26:09 UTC) #4
michaelpg
LGTM! Just update the title.
5 years, 8 months ago (2015-04-15 22:52:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051763004/40001
5 years, 8 months ago (2015-04-15 22:54:18 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-16 00:04:49 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 00:06:33 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ba1fe2ec13702f1ebf7294f798f73a158d0578f
Cr-Commit-Position: refs/heads/master@{#325353}

Powered by Google App Engine
This is Rietveld 408576698