chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1051763004: Convert *.css files to *_style.html files for the following custom elements: date_time_page, setting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1051763004: Convert *.css files to *_style.html files for the following custom elements: date_time_page, setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lot more files/styles. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.css ('k') | chrome/browser/resources/settings/settings_menu/settings_menu_style.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">	1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">	2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

	3 <link rel="import" href="settings_menu_style.html">

3	4

4 <polymer-element name="cr-settings-menu">	5 <polymer-element name="cr-settings-menu">

5 <template>	6 <template>

6 <link rel="stylesheet" href="settings_menu.css">	7 <core-style ref="settingsMenuStyle"></core-style>

7 <!-- TODO(jlklein): selectedAttribute here is a workaround for	8 <!-- TODO(jlklein): selectedAttribute here is a workaround for

8 https://github.com/Polymer/polymer/issues/946. Remove when core-menu	9 https://github.com/Polymer/polymer/issues/946. Remove when core-menu

9 is updated. -->	10 is updated. -->

10 <core-menu selected="{{selectedId}}" valueattr="data-id"	11 <core-menu selected="{{selectedId}}" valueattr="data-id"

11 selectedAttribute="">	12 selectedAttribute="">

12 <template repeat="{{pages}}">	13 <template repeat="{{pages}}">

13 <paper-item data-id="{{PAGE_ID}}">	14 <paper-item data-id="{{PAGE_ID}}">

14 <core-icon icon="{{icon}}"></core-icon>	15 <core-icon icon="{{icon}}"></core-icon>

15 {{pageTitle}}	16 {{pageTitle}}

16 </paper-item>	17 </paper-item>

17 </template>	18 </template>

18 </core-menu>	19 </core-menu>

19 </template>	20 </template>

20 <script src="settings_menu.js"></script>	21 <script src="settings_menu.js"></script>

21 </polymer-element>	22 </polymer-element>

OLD	NEW