Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1051683003: I suspect S32A_D565_Opaque_neon for Daisy problems. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

I suspect S32A_D565_Opaque_neon for Daisy problems. I don't see any color-order handling logic in the 32-bit code. BUG=skia:1843 CQ_EXCLUDE_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-Trybot,Build-Win-MSVC-x86_64-Debug-Trybot R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/3f55eed73f5af405909c2c10bff179d80526d423

Patch Set 1 #

Patch Set 2 : Fix? #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein
lgtm
5 years, 8 months ago (2015-04-02 19:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051683003/1
5 years, 8 months ago (2015-04-02 19:17:41 UTC) #4
mtklein
lgtm
5 years, 8 months ago (2015-04-02 19:31:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051683003/20001
5 years, 8 months ago (2015-04-02 19:32:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051683003/20001
5 years, 8 months ago (2015-04-02 19:38:56 UTC) #11
mtklein_C
5 years, 8 months ago (2015-04-02 19:41:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3f55eed73f5af405909c2c10bff179d80526d423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698