src/opts/SkBlitRow_opts_arm_neon.cpp - Issue 1051683003: I suspect S32A_D565_Opaque_neon for Daisy problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkBlitRow_opts_arm_neon.cpp

Issue 1051683003: I suspect S32A_D565_Opaque_neon for Daisy problems. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/opts/SkBlitRow_opts_arm_neon.cpp

diff --git a/src/opts/SkBlitRow_opts_arm_neon.cpp b/src/opts/SkBlitRow_opts_arm_neon.cpp

index 4465ff6ef5190c9cd6bb2a4739cec198fd868bc5..85287af62379abb3a0c137f1e93e5bc3dac3ca50 100644

--- a/src/opts/SkBlitRow_opts_arm_neon.cpp

+++ b/src/opts/SkBlitRow_opts_arm_neon.cpp

@@ -246,13 +246,19 @@ void S32A_D565_Opaque_neon(uint16_t* SK_RESTRICT dst,

"vaddhn.u16 d6, q14, q8 \n\t"

"vshr.u16 q8, q12, #5 \n\t"

"vaddhn.u16 d5, q13, q9 \n\t"

- "vqadd.u8 d6, d6, d0 \n\t" // moved up

"vaddhn.u16 d4, q12, q8 \n\t"

// intentionally don't calculate alpha

// result in d4-d6

+ #ifdef SK_PMCOLOR_IS_RGBA

+ "vqadd.u8 d6, d6, d0 \n\t"

"vqadd.u8 d5, d5, d1 \n\t"

"vqadd.u8 d4, d4, d2 \n\t"

+ #else

+ "vqadd.u8 d6, d6, d2 \n\t"

+ "vqadd.u8 d5, d5, d1 \n\t"

+ "vqadd.u8 d4, d4, d0 \n\t"

+ #endif

// pack 8888 {d4-d6} to 0565 q10

"vshll.u8 q10, d6, #8 \n\t"

@@ -326,13 +332,19 @@ void S32A_D565_Opaque_neon(uint16_t* SK_RESTRICT dst,