Index: site/dev/sheriffing/index.md |
diff --git a/site/dev/sheriffing/index.md b/site/dev/sheriffing/index.md |
index 59f496d94961f69e49ac2989fd6a3187f919d9a4..51f6aa927a9257eabac2c0ef6293f1b0f6e70843 100644 |
--- a/site/dev/sheriffing/index.md |
+++ b/site/dev/sheriffing/index.md |
@@ -112,3 +112,29 @@ See the revert documentation [here](https://skia.org/dev/contrib/revert). |
### What to do if DEPS roll fails to land |
A common cause of DEPS roll failures are layout tests. Find the offending Skia CL by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds. |
+ |
+<a name="how_to_rebaseline"</a> |
+### Rebaseline Layout Tests (i.e., add suppressions) |
rmistry
2015/04/03 14:54:33
When would the sheriff need to do this?
Maybe you
scroggo
2015/04/06 17:44:52
Done.
|
+ |
+1. First create a Chromium bug: |
+ * goto crbug.com |
rmistry
2015/04/03 14:54:33
Making this a link might be useful.
scroggo
2015/04/06 17:44:53
Done.
|
+ * Make sure you’re logged in with your Chromium credentials |
+ * Click “New Issue” |
+ * Summary: “Skia image rebaseline” |
+ * Description: |
+ * DEPS roll #, |
scroggo
2015/04/03 13:43:13
I was trying to indent this further, but did not k
rmistry
2015/04/03 14:54:33
The documentation is here: https://skia.org/dev/to
jcgregorio
2015/04/06 17:57:21
Yes, it is two spaces, see the nested list on this
scroggo
2015/04/06 18:01:44
Yeah, that's the page I'm looking at, and my lates
|
+ * helpful message about what went wrong (e.g., “Changes to how lighting is scaled in Skia r#### changed the following images:”) |
rmistry
2015/04/03 14:54:34
Nit: helpful -> Helpful
scroggo
2015/04/06 17:44:53
Done.
|
+ * layout tests effected |
rmistry
2015/04/03 14:54:33
Nit: layout -> Layout
scroggo
2015/04/06 17:44:52
Done.
|
+ * You should copy the list of affected from stdio of the failing bot |
+ * Status: Assigned |
+ * Owner: fmalita@ |
+ * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes |
+ * Labels: OS-All & Cr-Blink-LayoutTests |
+ * If it is filter related, cc senorblanco@ |
+ |
+2. Edit skia/skia_test_expectations.txt |
rmistry
2015/04/03 14:54:34
A link to the file in googlesource might be useful
scroggo
2015/04/06 17:44:52
Done.
|
+ * Add # comment about what has changed (I usually paraphrase the crbug text) |
+ * Add line(s) like after the comment: |
+ * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ] |
+ |
+3. Commit the changes and fire off new try bots (you usually only need to fire off the layout bots) |