OLD | NEW |
---|---|
1 Tree Sheriffs Documentation | 1 Tree Sheriffs Documentation |
2 =========================== | 2 =========================== |
3 | 3 |
4 ### Contents ### | 4 ### Contents ### |
5 | 5 |
6 * [What does a sheriff do?](#what_is_a_sheriff) | 6 * [What does a sheriff do?](#what_is_a_sheriff) |
7 + [Skia tree](#skia_tree) | 7 + [Skia tree](#skia_tree) |
8 + [DEPS rolls](#deps_rolls) | 8 + [DEPS rolls](#deps_rolls) |
9 + [Gold and Perf](#gold_and_perf) | 9 + [Gold and Perf](#gold_and_perf) |
10 + [Documentation](#sheriff_doc) | 10 + [Documentation](#sheriff_doc) |
11 * [View current and upcoming sheriffs](#view_current_upcoming_sheriffs) | 11 * [View current and upcoming sheriffs](#view_current_upcoming_sheriffs) |
12 * [How to swap sheriff shifts](#how_to_swap) | 12 * [How to swap sheriff shifts](#how_to_swap) |
13 * [Tips for sheriffs](#tips) | 13 * [Tips for sheriffs](#tips) |
14 + [When to file bugs](#when_to_file_bugs) | 14 + [When to file bugs](#when_to_file_bugs) |
15 + [How to close or re-open the tree](#how_close_tree) | 15 + [How to close or re-open the tree](#how_close_tree) |
16 + [Compile bot failures automatically close the tree](#tree_closers) | 16 + [Compile bot failures automatically close the tree](#tree_closers) |
17 + [How to revert a CL](#how_to_revert) | 17 + [How to revert a CL](#how_to_revert) |
18 + [What to do if DEPS roll fails to land](#deps_roll_failures) | 18 + [What to do if DEPS roll fails to land](#deps_roll_failures) |
rmistry
2015/04/03 14:54:33
Also add a link here to your new section.
scroggo
2015/04/06 17:44:52
Done.
| |
19 | 19 |
20 | 20 |
21 <a name="what_is_a_sheriff"></a> | 21 <a name="what_is_a_sheriff"></a> |
22 What does a sheriff do? | 22 What does a sheriff do? |
23 ----------------------- | 23 ----------------------- |
24 | 24 |
25 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. | 25 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. |
26 | 26 |
27 Below is a brief summary of what the sheriff does for each task: | 27 Below is a brief summary of what the sheriff does for each task: |
28 | 28 |
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
105 <a name="how_to_revert"></a> | 105 <a name="how_to_revert"></a> |
106 ### How to revert a CL | 106 ### How to revert a CL |
107 | 107 |
108 See the revert documentation [here](https://skia.org/dev/contrib/revert). | 108 See the revert documentation [here](https://skia.org/dev/contrib/revert). |
109 | 109 |
110 | 110 |
111 <a name="deps_roll_failures"></a> | 111 <a name="deps_roll_failures"></a> |
112 ### What to do if DEPS roll fails to land | 112 ### What to do if DEPS roll fails to land |
113 | 113 |
114 A common cause of DEPS roll failures are layout tests. Find the offending Skia C L by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds. | 114 A common cause of DEPS roll failures are layout tests. Find the offending Skia C L by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds. |
115 | |
116 <a name="how_to_rebaseline"</a> | |
117 ### Rebaseline Layout Tests (i.e., add suppressions) | |
rmistry
2015/04/03 14:54:33
When would the sheriff need to do this?
Maybe you
scroggo
2015/04/06 17:44:52
Done.
| |
118 | |
119 1. First create a Chromium bug: | |
120 * goto crbug.com | |
rmistry
2015/04/03 14:54:33
Making this a link might be useful.
scroggo
2015/04/06 17:44:53
Done.
| |
121 * Make sure you’re logged in with your Chromium credentials | |
122 * Click “New Issue” | |
123 * Summary: “Skia image rebaseline” | |
124 * Description: | |
125 * DEPS roll #, | |
scroggo
2015/04/03 13:43:13
I was trying to indent this further, but did not k
rmistry
2015/04/03 14:54:33
The documentation is here: https://skia.org/dev/to
jcgregorio
2015/04/06 17:57:21
Yes, it is two spaces, see the nested list on this
scroggo
2015/04/06 18:01:44
Yeah, that's the page I'm looking at, and my lates
| |
126 * helpful message about what went wrong (e.g., “Changes to how lighting is sca led in Skia r#### changed the following images:”) | |
rmistry
2015/04/03 14:54:34
Nit: helpful -> Helpful
scroggo
2015/04/06 17:44:53
Done.
| |
127 * layout tests effected | |
rmistry
2015/04/03 14:54:33
Nit: layout -> Layout
scroggo
2015/04/06 17:44:52
Done.
| |
128 * You should copy the list of affected from stdio of the failing bot | |
129 * Status: Assigned | |
130 * Owner: fmalita@ | |
131 * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes | |
132 * Labels: OS-All & Cr-Blink-LayoutTests | |
133 * If it is filter related, cc senorblanco@ | |
134 | |
135 2. Edit skia/skia_test_expectations.txt | |
rmistry
2015/04/03 14:54:34
A link to the file in googlesource might be useful
scroggo
2015/04/06 17:44:52
Done.
| |
136 * Add # comment about what has changed (I usually paraphrase the crbug text) | |
137 * Add line(s) like after the comment: | |
138 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ] | |
139 | |
140 3. Commit the changes and fire off new try bots (you usually only need to fire o ff the layout bots) | |
OLD | NEW |