Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1051363003: Correct property descriptors on GeneratorPrototype (Closed)

Created:
5 years, 8 months ago by mike3
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correct property descriptors on GeneratorPrototype The ES6 specification does not explicitly state the attributes for the 'next' and 'throw' property descriptors, so their values are defined by Section 17 [1]: > Every other data property described in clauses 18 through 26 and in > Annex B.2 has the attributes > { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true } > unless otherwise specified. [1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-ecmascript-standard-built-in-objects BUG=v8:3986 LOG=N R=wingo,arv Committed: https://crrev.com/0a4881600d0a7162038f54969ba521c58f4e6e4d Cr-Commit-Position: refs/heads/master@{#27770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/generator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-runtime.js View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
mike3
Hi Erik: could you please take a look? Also, I referenced the V8 bug ID ...
5 years, 8 months ago (2015-04-02 19:11:35 UTC) #2
arv (Not doing code reviews)
On 2015/04/02 19:11:35, mike3 wrote: > Hi Erik: could you please take a look? > ...
5 years, 8 months ago (2015-04-02 19:20:22 UTC) #3
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-02 19:21:52 UTC) #5
wingo
On 2015/04/02 19:21:52, arv wrote: > LGTM lgtm as well, adding to cq
5 years, 8 months ago (2015-04-10 14:30:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051363003/1
5 years, 8 months ago (2015-04-10 14:31:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1898)
5 years, 8 months ago (2015-04-10 14:50:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051363003/1
5 years, 8 months ago (2015-04-11 20:50:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-11 21:14:25 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 21:14:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a4881600d0a7162038f54969ba521c58f4e6e4d
Cr-Commit-Position: refs/heads/master@{#27770}

Powered by Google App Engine
This is Rietveld 408576698