Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1051253002: tidy up chromeos_setup.sh (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

tidy up chromeos_setup.sh - remove unused alex - streamline Link's config - remove misleading Daisy config: 1) armv7=1 does nothing. We meant to type arm_version=7 here. 2) arm_neon=1 does nothing unless arm_version == 7. 3) arm_thumb=0 is the default when arm_version <= 7. 4) skia_arch_width=32 is the default when skia_arch_type=arm. I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and arm_thumb=1, which I'm going to separately make the default for arm_version=7), but there are known color-order bugs with our NEON procs that would make Daisy start pushing bad images to Gold. Going to take baby steps here... BUG=skia:1843 Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot Committed: https://skia.googlesource.com/skia/+/cb49c07b7361029ba9992ca05f0f2aa5a79a52f5

Patch Set 1 #

Patch Set 2 : restore arm_thumb=0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M platform_tools/chromeos/bin/chromeos_setup.sh View 1 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mtklein_C
5 years, 8 months ago (2015-04-02 14:48:01 UTC) #2
borenet
LGTM
5 years, 8 months ago (2015-04-02 15:40:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051253002/1
5 years, 8 months ago (2015-04-02 15:45:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a
5 years, 8 months ago (2015-04-02 15:52:47 UTC) #6
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1059443002/ by mtklein@google.com. ...
5 years, 8 months ago (2015-04-02 16:01:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051253002/20001
5 years, 8 months ago (2015-04-02 16:05:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051253002/20001
5 years, 8 months ago (2015-04-02 16:13:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051253002/20001
5 years, 8 months ago (2015-04-02 16:21:02 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 16:28:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cb49c07b7361029ba9992ca05f0f2aa5a79a52f5

Powered by Google App Engine
This is Rietveld 408576698