Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: platform_tools/chromeos/bin/chromeos_setup.sh

Issue 1051253002: tidy up chromeos_setup.sh (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: restore arm_thumb=0 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/chromeos/bin/chromeos_setup.sh
diff --git a/platform_tools/chromeos/bin/chromeos_setup.sh b/platform_tools/chromeos/bin/chromeos_setup.sh
index e2dc32b34edaf3a17991ebb30a1f10b76fd74a60..d8103e9b8424af2ca6a0f9cfd682728e6ea1d4de 100755
--- a/platform_tools/chromeos/bin/chromeos_setup.sh
+++ b/platform_tools/chromeos/bin/chromeos_setup.sh
@@ -1,4 +1,10 @@
# Set up the environment to build Skia for ChromeOS.
+###############################################################################
+# Copyright 2015 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+###############################################################################
function exportVar {
NAME=$1
@@ -23,16 +29,13 @@ setup_device() {
DEFINES="OS=linux host_os=linux skia_os=chromeos skia_gpu=0"
case $TARGET_DEVICE in
- x86-alex)
- DEFINES="${DEFINES} skia_arch_type=x86 skia_arch_width=32"
- GENERIC_BOARD_TYPE="x86-generic"
- ;;
link)
- DEFINES="${DEFINES} skia_arch_type=x86 skia_arch_width=64"
+ DEFINES="${DEFINES} skia_arch_type=x86_64"
GENERIC_BOARD_TYPE="amd64-generic"
;;
daisy)
- DEFINES="${DEFINES} skia_arch_type=arm arm_neon=1 armv7=1 arm_thumb=0 skia_arch_width=32"
+ # TODO(mtklein): make this arm_version=7 and arm_neon=1
+ DEFINES="${DEFINES} skia_arch_type=arm arm_thumb=0"
# TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm
# build, which throws lots of "mangling of va_list has changed" warnings.
DEFINES="${DEFINES} skia_warnings_as_errors=0"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698