Non-SFI: move socketpair() from plugin process to browser process.

components/nacl/common/nacl_types.h

Index: components/nacl/common/nacl_types.h
diff --git a/components/nacl/common/nacl_types.h b/components/nacl/common/nacl_types.h
index f691edf9b2f7c6068efb3f686337ada1e994b7b6..084982e3c1a794346dcb29fde61d30439f2dd163 100644
--- a/components/nacl/common/nacl_types.h
+++ b/components/nacl/common/nacl_types.h
@@ -103,6 +103,18 @@ struct NaClStartParams {
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 
+  // In Non-SFI mode, to be more secure we cannot create socket pairs in the
+  // nacl_helper process. Instead, we create them in the browser process,
+  // and pass them to the plugin process.
+  FileDescriptor browser_server_ppapi_fd;

[Mark Seaborn, 2015/04/15 20:52:05]

base::FileDescriptor doesn't have a destructor...

Does base::File work in Chrome IPC messages these days?  If so, that would be
more robust about freeing FDs.

[hidehiko, 2015/05/12 18:47:51]

Ack.

On 2015/04/15 20:52:05, Mark Seaborn wrote:
No.

+  FileDescriptor browser_client_ppapi_fd;
+  FileDescriptor renderer_server_ppapi_fd;
+  FileDescriptor renderer_client_ppapi_fd;
+  FileDescriptor manifest_service_server_fd;
+  FileDescriptor manifest_service_client_fd;
+  FileDescriptor trusted_channel_server_fd;
+  FileDescriptor trusted_channel_client_fd;
+
   // NOTE: Any new fields added here must also be added to the IPC
   // serialization in nacl_messages.h and (for POD fields) the constructor
   // in nacl_types.cc.