Non-SFI: move socketpair() from plugin process to browser process.

components/nacl/common/nacl_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 #define COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 85 matching lines @@
   bool enable_ipc_proxy;
 
   // Enables plugin code to use Mojo APIs. See mojo/nacl for details.
   bool enable_mojo;
 
   NaClAppProcessType process_type;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 
+  // In Non-SFI mode, to be more secure we cannot create socket pairs in the
+  // nacl_helper process. Instead, we create them in the browser process,
+  // and pass them to the plugin process.
+  FileDescriptor browser_server_ppapi_fd;

[Mark Seaborn, 2015/04/15 20:52:05]

base::FileDescriptor doesn't have a destructor...

Does base::File work in Chrome IPC messages these days?  If so, that would be
more robust about freeing FDs.

[hidehiko, 2015/05/12 18:47:51]

Ack.

On 2015/04/15 20:52:05, Mark Seaborn wrote:
No.

+  FileDescriptor browser_client_ppapi_fd;
+  FileDescriptor renderer_server_ppapi_fd;
+  FileDescriptor renderer_client_ppapi_fd;
+  FileDescriptor manifest_service_server_fd;
+  FileDescriptor manifest_service_client_fd;
+  FileDescriptor trusted_channel_server_fd;
+  FileDescriptor trusted_channel_client_fd;
+
   // NOTE: Any new fields added here must also be added to the IPC
   // serialization in nacl_messages.h and (for POD fields) the constructor
   // in nacl_types.cc.
 };
 
 // Parameters sent to the browser process to have it launch a NaCl process.
 //
 // If you change this, you will also need to update the IPC serialization in
 // nacl_host_messages.h.
 struct NaClLaunchParams {
@@ skipping 56 matching lines @@
   base::ProcessId plugin_pid;
   int plugin_child_id;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_COMMON_NACL_TYPES_H_