Issue 105123002: Revert 238718 "Fix non-goma android build after r238630"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105123002: Revert 238718 "Fix non-goma android build after r238630" (Closed)

Created:
7 years ago by boliu

Modified:
7 years ago

Reviewers:
boliu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 238718 "Fix non-goma android build after r238630" Broke gyp on chromeos bot (possibly others) > Fix non-goma android build after r238630 > > dirname outputs "." when given an empty argument, which gyp rules then > interpret as goma being available. > > Remove ANDROID_GOMA_WRAPPER which is no longer used, and use GOMA_DIR > directly for android build. > > BUG= > NOTRY=true > > Review URL: https://codereview.chromium.org/104563004 TBR=boliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238719

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	trunk/src/build/android/envsetup.sh	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	trunk/src/build/common.gypi	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r238719.

Expand Messages | Collapse Messages