Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 104563004: Fix non-goma android build after r238630 (Closed)

Created:
7 years ago by boliu
Modified:
7 years ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, kma1
Visibility:
Public.

Description

Fix non-goma android build after r238630 dirname outputs "." when given an empty argument, which gyp rules then interpret as goma being available. Remove ANDROID_GOMA_WRAPPER which is no longer used, and use GOMA_DIR directly for android build. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238718 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238727

Patch Set 1 #

Patch Set 2 : fix all other platforms #

Patch Set 3 : Fix all other platforms (for realz this time) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/android/envsetup.sh View 2 chunks +0 lines, -3 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
boliu
I don't actually use goma, so don't know how folks usually enable it, but it ...
7 years ago (2013-12-04 17:15:18 UTC) #1
Nico
lgtm I think the android buildbots had issues due to a previous iteration of this ...
7 years ago (2013-12-04 17:23:27 UTC) #2
boliu
Ok, android trybots passed compile (in reasonable amount of time). Fingers crossed!
7 years ago (2013-12-04 17:45:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/104563004/1
7 years ago (2013-12-04 17:46:54 UTC) #4
commit-bot: I haz the power
Change committed as 238718
7 years ago (2013-12-04 17:48:11 UTC) #5
boliu
Well, that was fast, broke gyp on chromeos...
7 years ago (2013-12-04 17:55:02 UTC) #6
boliu
android_goma_dir needs to be defined even on non-android builds, so removing the else block broke ...
7 years ago (2013-12-04 18:06:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/104563004/40001
7 years ago (2013-12-04 18:35:32 UTC) #8
commit-bot: I haz the power
Change committed as 238727
7 years ago (2013-12-04 18:35:40 UTC) #9
Yoshisato Yanagisawa
7 years ago (2013-12-05 01:49:02 UTC) #10
Message was sent while issue was closed.
Thank you for fixing.

Powered by Google App Engine
This is Rietveld 408576698