Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1051123002: cc: Trigger BeginImplFrameDeadline immediately when invisible. (Closed)

Created:
5 years, 8 months ago by mithro-old
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Trigger BeginImplFrameDeadline immediately when invisible. When becoming invisible we are going to abort any pending draw / activate. We should do that right now rather then waking up sometime in the future and doing it. This increases the speed at which we become idle after going invisible. A minor side effect is we will do more work if we become invisible and then visible within a single frame, but this case is extremely unlikely while the case compared to becoming invisible for a longer period. Related to http://crrev.com/1050833002 BUG=371747 R=brianderson,jdduke Committed: https://crrev.com/c7c617b8619518568d2267015a5ee32aed7df883 Cr-Commit-Position: refs/heads/master@{#323397} Committed: https://crrev.com/5f4e78e22a976ecc32606e5ee30d7955635881fd Cr-Commit-Position: refs/heads/master@{#324383}

Patch Set 1 #

Patch Set 2 : Rebase onto master. #

Patch Set 3 : Rebase onto master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
mithro-old
Hi Brian, Here is the BeginImplFrameDeadline change split out from https://codereview.chromium.org/1050833002. Will rebase the other ...
5 years, 8 months ago (2015-04-02 00:30:52 UTC) #2
brianderson
lgtm
5 years, 8 months ago (2015-04-02 00:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051123002/1
5 years, 8 months ago (2015-04-02 01:04:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 01:57:00 UTC) #6
tommycli
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1058983002/ by tommycli@chromium.org. ...
5 years, 8 months ago (2015-04-02 18:44:40 UTC) #7
sunnyps
On 2015/04/02 18:44:40, tommycli wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 8 months ago (2015-04-02 18:47:57 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c7c617b8619518568d2267015a5ee32aed7df883 Cr-Commit-Position: refs/heads/master@{#323397}
5 years, 8 months ago (2015-04-03 20:21:12 UTC) #9
mithro-old
This patch was reverted in https://codereview.chromium.org/1051123002/
5 years, 8 months ago (2015-04-07 01:10:16 UTC) #10
mithro-old
On 2015/04/07 01:10:16, mithro wrote: > This patch was reverted in https://codereview.chromium.org/1051123002/ Sorry, that should ...
5 years, 8 months ago (2015-04-07 07:55:07 UTC) #11
mithro-old
The test which caused this patch to be reverted has been disabled in https://codereview.chromium.org/1069803003 I ...
5 years, 8 months ago (2015-04-09 04:52:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051123002/40001
5 years, 8 months ago (2015-04-09 05:35:10 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 05:38:48 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 05:39:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f4e78e22a976ecc32606e5ee30d7955635881fd
Cr-Commit-Position: refs/heads/master@{#324383}

Powered by Google App Engine
This is Rietveld 408576698