Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1069803003: Disabling flaky WebViewTest.Shim_TestAutosizeWithPartialAttributes (Closed)

Created:
5 years, 8 months ago by mithro-old
Modified:
5 years, 8 months ago
Reviewers:
fsamuel, lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky WebViewTest.Shim_TestAutosizeWithPartialAttributes This test (for unknown reasons) depends on the frame being visible and currently only passes because of an artificial delay in the compositor when going invisible. This is probably way it is already disabled on Mac and Windows. The patch at http://crrev.com/1051123002 removes this delay causing this test to become extremely flaky. See http://crbug.com/282116 BUG=282116 R=lazyboy,fsamuel Committed: https://crrev.com/7d9a86fc462441c654225f54648a865eb86617df Cr-Commit-Position: refs/heads/master@{#324387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mithro-old
Hi, This patch disables a flaky test you own. See the patch description and bug ...
5 years, 8 months ago (2015-04-09 04:40:06 UTC) #1
lazyboy
lgtm
5 years, 8 months ago (2015-04-09 04:50:51 UTC) #2
mithro-old
On 2015/04/09 at 04:50:51, lazyboy wrote: > lgtm Thanks for the speedy reply! Submitting.
5 years, 8 months ago (2015-04-09 04:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069803003/1
5 years, 8 months ago (2015-04-09 04:52:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 06:48:23 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 06:49:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9a86fc462441c654225f54648a865eb86617df
Cr-Commit-Position: refs/heads/master@{#324387}

Powered by Google App Engine
This is Rietveld 408576698