Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1050883002: [Android] Reland cleanup of old_interface in build/android/pylib. (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 8 months ago
Reviewers:
klundberg, perezju
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reland cleanup of old_interface in build/android/pylib. Original CL: https://codereview.chromium.org/1047703002/ BUG=267773 Committed: https://crrev.com/fccfe475db5c776bef8dbb27451b2f43c6e6ebab Cr-Commit-Position: refs/heads/master@{#323518}

Patch Set 1 : original #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -74 lines) Patch
M build/android/pylib/base/base_test_runner.py View 3 chunks +1 line, -5 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 chunks +18 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_options.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 2 chunks +14 lines, -8 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/host_driven/setup.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 2 chunks +1 line, -6 lines 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 2 chunks +8 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/test_options.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/linker/setup.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/linker/test_runner.py View 2 chunks +3 lines, -6 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/screenshot.py View 2 chunks +7 lines, -3 lines 0 comments Download
M build/android/pylib/uiautomator/test_options.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +10 lines, -9 lines 0 comments Download
M build/android/test_runner.py View 4 chunks +0 lines, -6 lines 0 comments Download
M build/android/update_verification.py View 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
5 years, 8 months ago (2015-04-01 13:39:41 UTC) #2
perezju
lgtm
5 years, 8 months ago (2015-04-01 13:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050883002/20001
5 years, 8 months ago (2015-04-02 16:04:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 17:00:30 UTC) #6
jbudorick
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1059443005/ by jbudorick@chromium.org. ...
5 years, 8 months ago (2015-04-02 22:03:11 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:26:55 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fccfe475db5c776bef8dbb27451b2f43c6e6ebab
Cr-Commit-Position: refs/heads/master@{#323518}

Powered by Google App Engine
This is Rietveld 408576698