build/android/pylib/perf/test_runner.py - Issue 1050883002: [Android] Reland cleanup of old_interface in build/android/pylib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/test_runner.py

Issue 1050883002: [Android] Reland cleanup of old_interface in build/android/pylib. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/perf/test_runner.py

diff --git a/build/android/pylib/perf/test_runner.py b/build/android/pylib/perf/test_runner.py

index da66d070dd375370b9df8e2c01d7e030d1b2278e..20f0fd08e3b002826e25e01ab7abef38573e3449 100644

--- a/build/android/pylib/perf/test_runner.py

+++ b/build/android/pylib/perf/test_runner.py

@@ -170,7 +170,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

tests: a dict mapping test_name to command.

flaky_tests: a list of flaky test_name.

"""

- super(TestRunner, self).__init__(device, None, 'Release')

+ super(TestRunner, self).__init__(device, None)

self._options = test_options

self._shard_index = shard_index

self._max_shard = max_shard

@@ -235,7 +235,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

try:

logging.warning('Unmapping device ports')

forwarder.Forwarder.UnmapAllDevicePorts(self.device)

- self.device.old_interface.RestartAdbdOnDevice()

+ self.device.RestartAdbd()

except Exception as e:

logging.error('Exception when tearing down device %s', e)

« no previous file with comments | « build/android/pylib/perf/perf_control.py ('k') | build/android/pylib/screenshot.py » ('j') | no next file with comments »