Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1050803002: [turbofan] cleanup InstructionOperand a little (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] cleanup InstructionOperand a little - ConstantOperand was using a too-small field too store its virtual register - drop ConvertTo, replace it with simple copy - split AllocatedOperand off from Immediate and Constant to make assignment clearer, also paving the way for small Immediates - put zone first in *Operand::New - driveby: drop delayed ssa deconstruction experiment R=titzer@chromium.org BUG= Committed: https://crrev.com/07ff6d9f22de49e5d9d8b2215864228e136a6cf5 Cr-Commit-Position: refs/heads/master@{#27692}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : everything working just need arches #

Patch Set 6 : arches #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -243 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/gap-resolver.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 2 chunks +13 lines, -10 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 1 2 3 6 chunks +151 lines, -70 lines 0 comments Download
M src/compiler/instruction.cc View 5 chunks +25 lines, -9 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/move-optimizer.cc View 1 2 3 4 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 21 chunks +60 lines, -80 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 2 3 4 chunks +25 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcarney
ptal
5 years, 8 months ago (2015-04-02 09:13:00 UTC) #2
Benedikt Meurer
lgtm
5 years, 8 months ago (2015-04-09 09:09:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050803002/140001
5 years, 8 months ago (2015-04-09 09:14:07 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 8 months ago (2015-04-09 09:15:33 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 09:15:44 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/07ff6d9f22de49e5d9d8b2215864228e136a6cf5
Cr-Commit-Position: refs/heads/master@{#27692}

Powered by Google App Engine
This is Rietveld 408576698