Remove stylesheet injection from Blink.

Remove stylesheet injection from Blink.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193159

[dcheng, 2015-04-02 05:31:55]

dcheng@chromium.org changed reviewers:
+ esprehn@chromium.org

[dcheng, 2015-04-02 05:31:56]

Delete all the codes. Requires that https://codereview.chromium.org/1058723002
and https://codereview.chromium.org/1052123002 land first.

[dcheng, 2015-04-02 06:54:18]

+pfeldman for the Source/devtools cleanups as well.

[dcheng, 2015-04-02 06:56:34]

dcheng@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dcheng, 2015-04-02 06:56:35]

(really +pfeldman this time)

[pfeldman, 2015-04-02 07:51:04]

On 2015/04/02 06:56:35, dcheng wrote:
> (really +pfeldman this time)

You should also remove "injected" from the protocol.json. Code will stop
compiling and you'll have to remove usages of
TypeBuilder::CSS::StyleSheetOrigin::Injected from core/inspector.

[dcheng, 2015-04-02 08:02:54]

On 2015/04/02 at 07:51:04, pfeldman wrote:
> On 2015/04/02 06:56:35, dcheng wrote:
> > (really +pfeldman this time)
> 
> You should also remove "injected" from the protocol.json. Code will stop
compiling and you'll have to remove usages of
TypeBuilder::CSS::StyleSheetOrigin::Injected from core/inspector.

Done. Thanks for pointing this out, I was having trouble finding it via
codesearch =)

[dcheng, 2015-04-02 08:17:58]

And it turns out I can't remove it: extension-injected stylesheets need to still
show "injected stylesheet". So I've reverted all the devtools changes.

Given that the extensions flow isn't tested at all atm, is it OK to proceed with
this cleanup and figure out how to add a testing hook for
WebDocument::injectStyleSheet in a separate patch?

[pfeldman, 2015-04-02 09:39:21]

I'd rather expose styleEngine().addAuthorSheet() via internals and migrate to it
while leaving the functionality and tests for inspector in place. Originally I
misunderstood the intent and thought that the entire concept was going away. It
got me wondering, but then I thought Okay, why not :)

[dcheng, 2015-04-02 14:02:18]

Given that the only caller of that function is
WebDocument::insertStyleSheet, I'd feel better exposing it via testRunner,
to avoid subtle diffs appearing between the setup to the call, since the
window.internals version would have to copy those steps.

On Thu, Apr 2, 2015, 17:39  <pfeldman@chromium.org> wrote:

> I'd rather expose styleEngine().addAuthorSheet() via internals and migrate
> to it
> while leaving the functionality and tests for inspector in place.
> Originally I
> misunderstood the intent and thought that the entire concept was going
> away. It
> got me wondering, but then I thought Okay, why not :)
>
> https://codereview.chromium.org/1050783003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[pfeldman, 2015-04-02 14:17:43]

On Thu, Apr 2, 2015 at 5:02 PM, Daniel Cheng <dcheng@chromium.org> wrote:

> Given that the only caller of that function is
> WebDocument::insertStyleSheet, I'd feel better exposing it via testRunner,
> to avoid subtle diffs appearing between the setup to the call, since the
> window.internals version would have to copy those steps.
>
You'd need to plumb it over IPC, which would make things async. Looking at
how simple WebDocument::insertStyleSheet is, I don't think it justifies,
but if you are ready to do all that work, I'm fine with it.


>
> On Thu, Apr 2, 2015, 17:39  <pfeldman@chromium.org> wrote:
>
>> I'd rather expose styleEngine().addAuthorSheet() via internals and migrate
>> to it
>> while leaving the functionality and tests for inspector in place.
>> Originally I
>> misunderstood the intent and thought that the entire concept was going
>> away. It
>> got me wondering, but then I thought Okay, why not :)
>>
>> https://codereview.chromium.org/1050783003/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[esprehn, 2015-04-03 21:22:57]

lgtm, this patch seems fine if pfeldman is happy. :)

[dcheng, 2015-04-04 13:16:19]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-04-04 13:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1050783003/60001

[commit-bot: I haz the power, 2015-04-04 14:27:17]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193159