Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1052123002: Remove stylesheet injection bindings for test runner. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stylesheet injection bindings for test runner. BUG= Committed: https://crrev.com/0fbe6af54316deb7339cedd0f96f692f03d12ccf Cr-Commit-Position: refs/heads/master@{#323878}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 5 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
Sending this out to get some initial thoughts and make sure I'm not missing something: ...
5 years, 8 months ago (2015-04-02 02:14:27 UTC) #2
dcheng
I've sent out the Blink CL for removing the layout tests in https://codereview.chromium.org/1058723002. The dependencies ...
5 years, 8 months ago (2015-04-02 04:44:33 UTC) #3
jochen (gone - plz use gerrit)
how are extensions injecting stylesheets?
5 years, 8 months ago (2015-04-02 07:55:33 UTC) #4
dcheng
On 2015/04/02 at 07:55:33, jochen wrote: > how are extensions injecting stylesheets? I think it's ...
5 years, 8 months ago (2015-04-02 07:59:04 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-02 08:16:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052123002/20001
5 years, 8 months ago (2015-04-04 03:40:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052123002/20001
5 years, 8 months ago (2015-04-04 07:09:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-04 07:25:03 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 07:25:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fbe6af54316deb7339cedd0f96f692f03d12ccf
Cr-Commit-Position: refs/heads/master@{#323878}

Powered by Google App Engine
This is Rietveld 408576698