Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1050453002: Update permission bubble strings with contextual verbs (Closed)

Created:
5 years, 8 months ago by felt
Modified:
5 years, 8 months ago
Reviewers:
meacer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update permission bubble strings with contextual verbs BUG=468600 R=meacer@chromium.org Committed: https://crrev.com/a9e0c0d8c6e22f0408bd5893f0978066df3de516 Cr-Commit-Position: refs/heads/master@{#323859}

Patch Set 1 #

Total comments: 4

Patch Set 2 : String changes for rolfe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 9 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
felt
meacer, ptal
5 years, 8 months ago (2015-03-31 10:31:41 UTC) #1
meacer
https://codereview.chromium.org/1050453002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1050453002/diff/1/chrome/app/generated_resources.grd#newcode13053 chrome/app/generated_resources.grd:13053: + Send notifications Shouldn't this be "Show notifications" instead? ...
5 years, 8 months ago (2015-03-31 18:10:40 UTC) #2
meacer
And I now realize you already mentioned MIDI and content identifier in the bug.
5 years, 8 months ago (2015-03-31 21:42:36 UTC) #3
felt
On 2015/03/31 21:42:36, Mustafa Emre Acer wrote: > And I now realize you already mentioned ...
5 years, 8 months ago (2015-03-31 21:43:50 UTC) #4
felt
I update the strings per the discussion on the bug
5 years, 8 months ago (2015-04-03 04:01:33 UTC) #5
meacer
On 2015/04/03 04:01:33, felt wrote: > I update the strings per the discussion on the ...
5 years, 8 months ago (2015-04-03 17:51:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050453002/20001
5 years, 8 months ago (2015-04-03 23:09:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-04 00:34:04 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:35:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9e0c0d8c6e22f0408bd5893f0978066df3de516
Cr-Commit-Position: refs/heads/master@{#323859}

Powered by Google App Engine
This is Rietveld 408576698