Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1050353002: [MacViews] Remove stray/unguarded uses of ui/aura/window.h in cross-platform files (Closed)

Created:
5 years, 8 months ago by tapted
Modified:
5 years, 8 months ago
Reviewers:
Andre, sky
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, jennb, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, Dmitry Titov, dcheng, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jianli, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MacViews] Remove stray/unguarded uses of ui/aura/window.h in cross-platform files The window.h header compiles on Mac, but its implementation isn't linked in, resulting in errors later. This CL was made by putting an #error in aura/window.h. Some of these #includes were simply redundant/unused. tab_drag_controller.cc changed recently in r321128 and relies on aura/window.h to implicitly cast an aura::Window to a ui::GestureConsumer. BUG=425229 Committed: https://crrev.com/3b74b439c3c1c102023a2dc92184ea02f38849cd Cr-Commit-Position: refs/heads/master@{#323535}

Patch Set 1 #

Patch Set 2 : fix browser_action_test_util goo #

Patch Set 3 : Fix panel_view.cc #

Patch Set 4 : Fix hung_renderer_view.cc #

Patch Set 5 : rebase off crrev/1054793002 #

Patch Set 6 : Pull out orthogonal stuff #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 chunks +7 lines, -1 line 1 comment Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/snapshot/screenshot_grabber.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/snapshot/screenshot_grabber.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sky, please take a look https://codereview.chromium.org/1050353002/diff/100001/chrome/browser/ui/views/tabs/tab_drag_controller.cc File chrome/browser/ui/views/tabs/tab_drag_controller.cc (right): https://codereview.chromium.org/1050353002/diff/100001/chrome/browser/ui/views/tabs/tab_drag_controller.cc#newcode595 chrome/browser/ui/views/tabs/tab_drag_controller.cc:595: #endif note that ...
5 years, 8 months ago (2015-04-02 10:38:22 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-02 17:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050353002/100001
5 years, 8 months ago (2015-04-02 17:24:50 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-02 17:43:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:27:42 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3b74b439c3c1c102023a2dc92184ea02f38849cd
Cr-Commit-Position: refs/heads/master@{#323535}

Powered by Google App Engine
This is Rietveld 408576698