Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1050313003: Handle EXC_RESOURCE and EXC_GUARD exceptions properly (Closed)

Created:
5 years, 8 months ago by Mark Mentovai
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Handle EXC_RESOURCE and EXC_GUARD exceptions properly. These two exception types use all 64 bits of the code[0] field. The ExceptionSnapshot was unprepared to stuff this into a 32-bit field. To resolve the discrepancy, the more-significant data is taken from the high 32 bits of code[0]. No information is lost because the full code[0] is made available as part of the Codes() vector. BUG=crashpad:34 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e1347a740c051d9a44aa2dd0b9d11067a53e0447

Patch Set 1 #

Patch Set 2 : EXC_RESOURCE #

Patch Set 3 : Document #

Patch Set 4 : implicit_cast<>() #

Patch Set 5 : Better logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -24 lines) Patch
M client/crashpad_client_mac.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M compat/non_win/dbghelp.h View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M handler/mac/crash_report_exception_handler.cc View 1 2 3 4 4 chunks +13 lines, -3 lines 0 comments Download
M snapshot/exception_snapshot.h View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M snapshot/mac/exception_snapshot_mac.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/exception_snapshot_mac.cc View 1 2 3 4 5 chunks +84 lines, -9 lines 0 comments Download
M snapshot/mac/process_snapshot_mac.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/mac/process_snapshot_mac.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark Mentovai
5 years, 8 months ago (2015-04-02 14:20:11 UTC) #3
Mark Mentovai
This is needed to diagnose https://crbug.com/461246.
5 years, 8 months ago (2015-04-02 18:22:48 UTC) #5
Robert Sesek
LGTM
5 years, 8 months ago (2015-04-02 19:40:31 UTC) #6
Mark Mentovai
5 years, 8 months ago (2015-04-02 19:49:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:110001) manually as
e1347a740c051d9a44aa2dd0b9d11067a53e0447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698