Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: compat/non_win/dbghelp.h

Issue 1050313003: Handle EXC_RESOURCE and EXC_GUARD exceptions properly (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Better logging Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crashpad_client_mac.cc ('k') | handler/mac/crash_report_exception_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compat/non_win/dbghelp.h
diff --git a/compat/non_win/dbghelp.h b/compat/non_win/dbghelp.h
index 21a58dc2cb9d4541e1541b4527c929be50cfae08..3be6e5af549a3e57593c1e964b4a95bcf5fc8afe 100644
--- a/compat/non_win/dbghelp.h
+++ b/compat/non_win/dbghelp.h
@@ -422,11 +422,15 @@ struct __attribute__((packed, aligned(4))) MINIDUMP_EXCEPTION {
//! operating system-specific values.
//!
//! For Mac OS X minidumps, this will be the value of the exception code at
- //! index 0 as received by a Mach exception handler. For exception type
- //! `EXC_CRASH` generated from another preceding exception, the original
- //! exception code will appear here, not the code as received by the Mach
- //! exception handler. The code as it was received will appear at index 1 of
- //! #ExceptionInformation.
+ //! index 0 as received by a Mach exception handler, except:
+ //! * For exception type `EXC_CRASH` generated from another preceding
+ //! exception, the original exception code will appear here, not the code
+ //! as received by the Mach exception handler.
+ //! * For exception types `EXC_RESOURCE` and `EXC_GUARD`, the high 32 bits of
+ //! the code received by the Mach exception handler will appear here.
+ //!
+ //! In all cases for Mac OS X minidumps, the code as it was received by the
+ //! Mach exception handler will appear at index 1 of #ExceptionInformation.
//!
//! \todo Document the possible values by OS. There may be OS-specific enums
//! in minidump_extensions.h.
@@ -456,7 +460,7 @@ struct __attribute__((packed, aligned(4))) MINIDUMP_EXCEPTION {
//! `codes[1]` (exception code and subcode) parameters supplied to the Mach
//! exception handler. Unlike #ExceptionCode and #ExceptionFlags, the values
//! received by a Mach exception handler are used directly here even for the
- //! `EXC_CRASH` exception type.
+ //! `EXC_CRASH`, `EXC_RESOURCE`, and `EXC_GUARD` exception types.
uint64_t ExceptionInformation[EXCEPTION_MAXIMUM_PARAMETERS];
};
« no previous file with comments | « client/crashpad_client_mac.cc ('k') | handler/mac/crash_report_exception_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698