Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 1050103003: Revert of Revert of Implement DisplayList GatherPixelRefs (Closed)

Created:
5 years, 8 months ago by weiliangc
Modified:
5 years, 8 months ago
Reviewers:
ajuma, vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chrishtr, chromium-reviews, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Implement DisplayList GatherPixelRefs (patchset #1 id:1 of https://codereview.chromium.org/1047413003/) Reason for revert: Break tree Original issue's description: > Revert of Implement DisplayList GatherPixelRefs (patchset #5 id:80001 of https://codereview.chromium.org/1045953002/) > > Reason for revert: > Cause of crbug.com/472590 > > Original issue's description: > > Implement DisplayList GatherPixelRefs > > > > Take advantage of DisplayList playing back to generate SkPicture, and > > use existing functions that gathers pixel ref from a single SkPicture. > > > > R=ajuma, enne, vmpstr > > BUG=440468 > > > > Committed: https://crrev.com/3d69b19b57904847ffec31b0f5d4f3568b5c6f35 > > Cr-Commit-Position: refs/heads/master@{#323152} > > TBR=enne@chromium.org,ajuma@chromium.org,vmpstr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=440468 > > Committed: https://crrev.com/74cb97d8d5c4e62a694c7f029a7c8c0b09e5bd92 > Cr-Commit-Position: refs/heads/master@{#323321} TBR=enne@chromium.org,ajuma@chromium.org,vmpstr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440468 Committed: https://crrev.com/2f958f4157655afa8e86afb0549fafe51b79f219 Cr-Commit-Position: refs/heads/master@{#323324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -437 lines) Patch
M cc/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M cc/resources/display_item_list.h View 3 chunks +6 lines, -0 lines 0 comments Download
M cc/resources/display_item_list.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/resources/display_list_raster_source.cc View 1 chunk +10 lines, -1 line 0 comments Download
M cc/resources/display_list_recording_source.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/resources/display_list_recording_source.cc View 3 chunks +5 lines, -1 line 0 comments Download
A cc/resources/display_list_recording_source_unittest.cc View 1 chunk +164 lines, -0 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 11 chunks +9 lines, -379 lines 0 comments Download
M cc/resources/pixel_ref_map.h View 3 chunks +5 lines, -1 line 0 comments Download
M cc/resources/pixel_ref_map.cc View 3 chunks +52 lines, -37 lines 0 comments Download
A cc/resources/recording_source_unittest.cc View 1 chunk +445 lines, -0 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 2 chunks +18 lines, -4 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 2 chunks +22 lines, -0 lines 0 comments Download
A cc/test/fake_display_list_recording_source.h View 1 chunk +88 lines, -0 lines 0 comments Download
M cc/test/fake_picture_pile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_pile.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
weiliangc
Created Revert of Revert of Implement DisplayList GatherPixelRefs
5 years, 8 months ago (2015-04-01 20:48:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050103003/1
5 years, 8 months ago (2015-04-01 20:49:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 20:50:43 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 20:51:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f958f4157655afa8e86afb0549fafe51b79f219
Cr-Commit-Position: refs/heads/master@{#323324}

Powered by Google App Engine
This is Rietveld 408576698