Issue 105003005: Revert of Teach Skia to use discardable memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105003005: Revert of Teach Skia to use discardable memory (Closed)

Created:
7 years ago by johnme

Modified:
7 years ago

Reviewers:
jamesr, Stephen White, Alpha Left Google

CC:
blink-reviews, jamesr, krit, dsinclair, danakj, Rik, Stephen Chennney, pdr., rwlbuis, reveman

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert of https://codereview.chromium.org/105773003/ Reason for revert: This patch made DeferredImageDecoderTest.drawDiscardableIntoSkPicture consistently fail on bot: WebKit Android (Nexus4) TBR=senorblanco@chromium.org,jamesr@chromium.org,hclam@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163776

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -261 lines)			Patch
M	Source/platform/blink_platform.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/platform/graphics/DecodingImageGenerator.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	Source/platform/graphics/DecodingImageGenerator.cpp	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	Source/platform/graphics/DeferredImageDecoder.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/platform/graphics/DeferredImageDecoder.cpp	View	5 chunks	+3 lines, -44 lines	0 comments	Download
M	Source/platform/graphics/ImageFrameGenerator.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/platform/graphics/ImageFrameGenerator.cpp	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	Source/web/tests/DeferredImageDecoderTest.cpp	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/105003005/1

7 years ago (2013-12-12 11:32:11 UTC) #2

Message was sent while issue was closed.

Change committed as 163776